Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jiqi Li" <lijq9@lenovo.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: Add driver for the NCT6801D EC sensor window
Date: Mon, 16 Nov 2026 12:18:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-217002@kernel.org> (raw)
In-Reply-To: <20261116120411.994284-2-lijq9@lenovo.com>

> The Nuvoton NCT6801D embedded controller does not expose a hardware
> monitor logical device in its Super-I/O configuration space: LDN 0Bh is
> the ATXPGD/BEEP/DDR4 block, so the eSIO-style register window that
> nct6683 relies on does not exist on this part.
> 
> Fan and temperature values are instead published by the EC firmware in
> one of the shared-memory windows of the SHM logical device (LDN 0Fh),
> which the platform firmware maps as
> 
> 	OperationRegion (SHWM, SystemMemory, <base>, 0xFF)
> 
> The window base is not hardcoded: it is read back from the SHAW1..SHAW5
> configuration registers (indices F7h-F4h, FBh-F8h, E3h-E0h, E7h-E4h and
> EBh-E8h of LDN 0Fh), as documented in the Datasheet. Several windows are
> normally enabled, so each candidate is checked for plausible sensor data
> [ ... ]
> ACPI TCPU reads 100.05 C, TCPU_PCI 100.00 C, x86_pkg_temp 100.00 C and
> coretemp 101.0 C, i.e. four independent sources agree within 1 C.
> Readings return to idle values when the load is removed.
> 
> Signed-off-by: Jiqi Li <lijq9@lenovo.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116120411.994284-2-lijq9@lenovo.com?part=1


  reply	other threads:[~2026-11-16 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:04 [PATCH v3] hwmon: Add NCT6801D EC sensor support for Lenovo workstations Jiqi Li
2026-11-16 12:04 ` [PATCH v3 1/2] hwmon: Add driver for the NCT6801D EC sensor window Jiqi Li
2026-11-16 12:18   ` sashiko-bot [this message]
2026-11-16 14:21   ` Guenter Roeck
2026-11-16 12:04 ` [PATCH v3 2/2] hwmon: Document the lenovo-shm-sensors driver Jiqi Li
2026-11-16 12:06   ` sashiko-bot
2026-11-16 14:22   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217002@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lijq9@lenovo.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox