From: sashiko-bot@kernel.org
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ltc2947) Make ltc2947.h self-contained
Date: Mon, 16 Nov 2026 18:15:26 +0000 [thread overview]
Message-ID: <sashiko-outbox-217493@kernel.org> (raw)
In-Reply-To: <20261116180950.3894659-2-u.kleine-koenig@baylibre.com>
> When ltc2947.h is included without a previous definition of
> of_device_id, the compiler wails:
>
> drivers/hwmon/ltc2947.h:11:34: error: array type has incomplete element type ‘struct of_device_id’
> 11 | extern const struct of_device_id ltc2947_of_match[];
> | ^~~~~~~~~~~~~~~~
>
> A forward declaration is not enough to fix that, so include the header
> providing `struct of_device_id`.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116180950.3894659-2-u.kleine-koenig@baylibre.com?part=1
next prev parent reply other threads:[~2026-11-16 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:09 [PATCH] hwmon: (ltc2947) Make ltc2947.h self-contained Uwe Kleine-König
2026-11-16 18:15 ` sashiko-bot [this message]
2026-11-16 19:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217493@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox