From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-hwmon@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH v5 1/6] dt-bindings: mfd: Describe the BCM6846 PMC complex
Date: Mon, 16 Nov 2026 23:57:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-217953@kernel.org> (raw)
In-Reply-To: <20261117-xg6846b-bcmbca-xrdp-reset-v5-1-f584e8b8e696@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: mfd: bcm6846-pmc: child nodes split PMB by Linux
subsystem
--
commit 7ec1ccaaf4e78fdfa9c9d3aeff900e6713c1dd94
Author: Linus Walleij <linusw@kernel.org>
dt-bindings: mfd: Describe the BCM6846 PMC complex
This commit adds the Devicetree binding schema and header constants for
the Broadcom BCM6846 Power Management Controller complex and its Power
Management Bus providers.
> diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
> new file mode 100644
> index 0000000000000..eb01797f82622
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
[ ... ]
> +patternProperties:
> + '^bus@[0-9a-f]+$':
> + type: object
> + description:
> + The Power Management Bus (PMB) connects the third generation Power
> + Management Controller (PMC3) to the control registers of miscellaneous
> + independent hardware blocks.
> +
> + The controller provides configuration, arbitration and four keyhole
> + interfaces for indirect register access.
> +
> + Child nodes describe independent hardware blocks accessed over the PMB.
> + These provide global resources and even resources for each other.
> +
> + properties:
> + compatible:
> + const: brcm,bcm6846-pmb
> +
> + reg:
> + maxItems: 1
> + description: PMB configuration, keyhole and address mapping registers
[ ... ]
> + required:
> + - compatible
> + - reg
> + - power-controller
> + - clock-controller
> + - reset-controller
> + - hwmon
[Severity: Medium]
As reported by Philipp Zabel on RFC [1], why are power-controller,
clock-controller, reset-controller, and hwmon modeled as separate
address-less child nodes rather than putting the provider cell properties
directly on the brcm,bcm6846-pmb node?
These child nodes partition the PMB keyhole interface by Linux subsystem
rather than independent hardware blocks, encoding the Linux MFD driver
split into the Devicetree ABI. In the driver patches in this series, the
power, clock, and reset drivers operate on shared BPCM slave devices over
the same regmap: brcm,bcm6846-pmb-power and brcm,bcm6846-pmb-clock modify
different bitfields of the same 32-bit BPCM zone control words (at word
offset 32 + zone * 8), and brcm,bcm6846-pmb-reset writes word offset 5 of
those same XRDP and Runner BPCM devices. Likewise, the clocks and resets
properties on the hwmon child node point to BCM6846_CLK_PVTMON and
BCM6846_RESET_PVTMON, which toggle bitfields (bits 12:8, 2, and 0) inside
PVTMON's own PVTMON_CONFIG register (bus 1, device 6, word 17) rather than
separate clock or reset hardware blocks.
Folding #power-domain-cells, #clock-cells, #reset-cells,
#thermal-sensor-cells, and the reference clock into the brcm,bcm6846-pmb
node avoids baking the Linux sub-driver split into the Devicetree ABI while
still allowing the MFD driver to instantiate child devices internally.
[1] https://lore.kernel.org/r/f1c24a603964302ec1462b1cea790a2a7079fb3d.camel@pengutronix.de
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-xg6846b-bcmbca-xrdp-reset-v5-0-f584e8b8e696@kernel.org?part=1
next prev parent reply other threads:[~2026-11-16 23:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 23:47 [PATCH v5 0/6] BCMBCA PMB power, clock, reset and hardware monitoring support Linus Walleij
2026-11-16 23:47 ` [PATCH v5 1/6] dt-bindings: mfd: Describe the BCM6846 PMC complex Linus Walleij
2026-11-16 23:57 ` sashiko-bot [this message]
2026-11-17 0:10 ` Linus Walleij
2026-11-16 23:47 ` [PATCH v5 2/6] mfd: bcmbca-pmb: Add a shared BCMBCA PMC3 PMB transport Linus Walleij
2026-11-16 23:58 ` sashiko-bot
2026-11-16 23:47 ` [PATCH v5 3/6] pmdomain: bcm: Add BCMBCA PMB power domains Linus Walleij
2026-11-16 23:56 ` sashiko-bot
2026-11-16 23:47 ` [PATCH v5 4/6] reset: Add BCMBCA block resets through the PMB Linus Walleij
2026-11-16 23:54 ` sashiko-bot
2026-11-16 23:47 ` [PATCH v5 5/6] clk: bcm: Add BCMBCA PMB clocks Linus Walleij
2026-11-16 23:56 ` sashiko-bot
2026-11-16 23:47 ` [PATCH v5 6/6] hwmon: Add Broadcom PMB PVTMON monitoring Linus Walleij
2026-11-16 23:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217953@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox