From: sashiko-bot@kernel.org
To: "Vítor Hugo Silva" <vitorhg20080@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()
Date: Wed, 18 Nov 2026 09:32:23 +0000 [thread overview]
Message-ID: <sashiko-outbox-220576@kernel.org> (raw)
In-Reply-To: <20261118092928.163553-1-vitorhg20080@gmail.com>
> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write to registers even if spi_setup() fails.
>
> Return the setup error before accessing any registers.
>
> AI was used for peer-review the patch.
>
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
>
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118092928.163553-1-vitorhg20080@gmail.com?part=1
prev parent reply other threads:[~2026-11-18 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:29 [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
2026-11-18 9:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220576@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vitorhg20080@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox