Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Guenter Roeck" <linux@roeck-us.net>,
	"Hardware Monitoring" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Fix collection check for Aquaero devices
Date: Sun, 22 Nov 2026 01:27:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-227610@kernel.org> (raw)
In-Reply-To: <20261122012528.881538-1-linux@roeck-us.net>

> Commit b7743c6dbe3a ("hwmon: (aquacomputer_d5next) Check maxcollection
> when probing AQUAERO devices") added a check rejecting devices with
> hdev->maxcollection < 2 before inspecting hdev->collection[1].type in
> aqc_probe().
> 
> Aquacomputer Aquaero 5 (0c70:f001) exposes three HID interfaces under
> the same product ID: "keyboard/mouse" (3 collections, with
> collection[1].type == 1), "System Control" (2 collections, with
> collection[1].type == 1), and "aquaero Device", which is the sensor
> interface the driver binds to and only presents a single vendor-defined
> top-level collection (maxcollection == 1).
> 
> Prior to that commit, probing "aquaero Device" worked because the HID
> core allocates HID_DEFAULT_NUM_COLLECTIONS (16) zero-filled entries for
> hdev->collection, so hdev->collection[1].type read as 0. Rejecting
> [ ... ]
> Fixes: b7743c6dbe3a ("hwmon: (aquacomputer_d5next) Check maxcollection when probing AQUAERO devices")
> Reported-by: Nandor Lieszkovszky <spoon3r73@googlemail.com>
> Link: https://lore.kernel.org/linux-hwmon/3b6ce200-ae89-4629-a05b-bcdc503871d3@gmail.com/
> Suggested-by: Nandor Lieszkovszky <spoon3r73@googlemail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122012528.881538-1-linux@roeck-us.net?part=1

  reply	other threads:[~2026-11-22  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  1:25 [PATCH] hwmon: (aquacomputer_d5next) Fix collection check for Aquaero devices Guenter Roeck
2026-11-22  1:27 ` sashiko-bot [this message]
2026-11-22 10:57 ` Aleksa Savic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227610@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox