linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
To: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	muislam@microsoft.com, easwar.hariharan@linux.microsoft.com,
	kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, longli@microsoft.com, mhklinux@outlook.com,
	skinsburskii@linux.microsoft.com, romank@linux.microsoft.com,
	Jinank Jain <jinankjain@microsoft.com>
Subject: Re: [PATCH v2] mshv: Extend create partition ioctl to support cpu features
Date: Fri, 31 Oct 2025 11:37:40 -0700	[thread overview]
Message-ID: <119f11e7-6074-4bd4-a72b-fc76370c284f@linux.microsoft.com> (raw)
In-Reply-To: <1761860431-11208-1-git-send-email-nunodasneves@linux.microsoft.com>

On 10/30/2025 2:40 PM, Nuno Das Neves wrote:
> From: Muminul Islam <muislam@microsoft.com>
> 
> The existing mshv create partition ioctl does not provide a way to
> specify which cpu features are enabled in the guest. This was done
> to reduce unnecessary complexity in the API.
> 
> However, some new scenarios require fine-grained control over the
> cpu feature bits.
> 
> Define a new mshv_create_partition_v2 structure which supports passing
> through the disabled cpu flags and xsave flags to the hypervisor
> directly.
> 
> When these are not specified (pt_num_cpu_fbanks == 0) or the old
> structure is used, define a set of default flags which cover most
> cases.
> 
> Retain backward compatibility with the old structure via a new flag
> MSHV_PT_BIT_CPU_AND_XSAVE_FEATURES which enables the new struct.
> 
> Co-developed-by: Jinank Jain <jinankjain@microsoft.com>
> Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
> Signed-off-by: Muminul Islam <muislam@microsoft.com>
> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> ---
> Changes in v2:
> - Fix compilation issues [kernel test robot]
> 
> ---
>  drivers/hv/mshv_root_main.c | 176 ++++++++++++++++++++++++++++++++----
>  include/hyperv/hvhdk.h      |  86 +++++++++++++++++-
>  include/uapi/linux/mshv.h   |  34 +++++++
>  3 files changed, 272 insertions(+), 24 deletions(-)

lkp also pointed out that we are leaking a kernel config to userspace:
https://lore.kernel.org/all/202510292330.LCHvPCLt-lkp@intel.com/

In the v3 that Wei requested, please address that as well.

Thanks,
Easwar (he/him)

<snip>

  parent reply	other threads:[~2025-10-31 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30 21:40 [PATCH v2] mshv: Extend create partition ioctl to support cpu features Nuno Das Neves
2025-10-31 18:31 ` Wei Liu
2025-10-31 20:08   ` Nuno Das Neves
2025-11-07 18:14     ` Wei Liu
2025-10-31 18:37 ` Easwar Hariharan [this message]
2025-10-31 19:49   ` Nuno Das Neves
2025-11-02 14:13 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=119f11e7-6074-4bd4-a72b-fc76370c284f@linux.microsoft.com \
    --to=easwar.hariharan@linux.microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=jinankjain@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=mhklinux@outlook.com \
    --cc=muislam@microsoft.com \
    --cc=nunodasneves@linux.microsoft.com \
    --cc=romank@linux.microsoft.com \
    --cc=skinsburskii@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).