From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89CDF257AFB for ; Thu, 11 Sep 2025 06:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757571753; cv=none; b=Ob+j7OtPCUDx9MQVP7fkmIFVnJc6A+CoVR1zuzKV4G0zRudfQ4LfWXosLsBVgcNiDXLbIUQsMnievWSMojq1fe1K3j0e7ijnuZEoIw8qNc3iIlCyaiu9qOUMll/ea9YUgfgKQEAFdVUeo+4D59rGJOQNYLic2kCMe+uwYUq8Gvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757571753; c=relaxed/simple; bh=hlj60Y3CDwbm3ISUClYbd/cRw9Aw6yeqtaG6vuuuXSo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=slu4n2PAqdRTk2fN7LlhyfVUGVlN/Qr73ITit5S7aeJXd9GnMJiUsy4Ll32LdYqmN/Uavv0Ra7gTeUVWFOInWaerqKausKWIzMNXbn4aIItWOhfcAIW3pfYbrRByWvUa3aAjwMr0wcBbRniQ0DGhERKa1DgBZNn0rbNUFGw7IXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XB7JAtkl; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XB7JAtkl" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45dfe95bbb7so3013455e9.1 for ; Wed, 10 Sep 2025 23:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757571750; x=1758176550; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cDPel/ZZYGzbUTLwzSWpGQzV6w/4oCA0HWnxnn69Plw=; b=XB7JAtklpU0SngvoNk/AF5LLYyCMdY6pVqKQDdZyIRGCUs5Ixk3fFj2p4s3knqns4l rJLPpVnZmTawqUY5mUKmcpHqHnLaSD3k+a8k4CZq+V/pMUcTYXUijOPH6/Gi09BDitzH kxR+D3m42/KVRHVAsoYu7Pj3C3gnEqQMalLYqt9LbHoHO0R42Q7zPSHcAxTlygVszWCF bBLDIyyhIcuXOsa1ApdI5TkkPpMV2JmS18tyh9IzjH4J9STeCejQiHhP+VG5MRKMi0Hh 1qnTKzvA6zeQaXs/BpazirMD/RM+fLFf2tEylK5Ii3bELxMBaU4g7RbqMFKbdDhQdBZy /NLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757571750; x=1758176550; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cDPel/ZZYGzbUTLwzSWpGQzV6w/4oCA0HWnxnn69Plw=; b=meVU1MZhJE0w9kkiDEUfgmUk0S2Ok5FF2axiIHMcc7pqYGCzN7ZESPOc4luYLWmej3 C+50cmfSjmtZ+aTW8Iq2aeHNckbidGENyCJ6ELjbPur/yg0fRdx/yVgfZXVBUE+Cxd1X HnhMJ3lnmJ0K/D+6VmLbmoUcm38BYjygcPO29eJTNtykgQNs+0uASjcL9653JFRhO5q/ st7b9kJrHUylIDHwHVzKMYOC7g04hRoea6zW0970LC00iKSNP6DAbbGEGaTHxI86fcrF 3Nkr5/Cm917qMM1VD1U6lIexCEcgCvkcqGBn/Oj42LfH23RTym2eyE5EIxEZuNIfZ5sv qjZA== X-Forwarded-Encrypted: i=1; AJvYcCUXPd5jq+MLNEF7bBckU08C1YcEI1q7zlwTY9NTPhv3b5zPQ9QGIXzXE64uCgsn/7ySvzTzHSa4pApNBF0=@vger.kernel.org X-Gm-Message-State: AOJu0YxT5YeUuOMEZndUQzyDQIm90ej/NJD9P1xgiB0LAhgqkKPXXFoS JTiWhA1Thjc1EqqfrkDEHrIYDgLODenlvWV5qNn2McnoB1/n5N9gkVFc X-Gm-Gg: ASbGncuj1NFWE0sN2IZxO+3J7N0ptO8VugBPAhyJx/ELTyX+jBFxvOCXRxY6FI02KPq ZS2ZjbGvQOfoRSy8b/rwhH47FpY9nXjyRdv1vb0HKkkiHmUyQWBiU8TKWoTBEItBXgYZKzohvht H4CxT6YcMaArYaAmdEoIlqLi346BZtejaF4cWOTJW6x5qsk1c8z5ipwzoSBxo5AHP1jXRzklOFz zgw7bFZxp6YSZWaoH2Y7SyYHS+MZk2fSzqm0MeC2D9EHZc87nK6kMd2FDzxSTRVTagnrbP92XGh 1yMVUU9+983ZGZ7slrUz3Eb4mJwnXGTAXpAyr8vBX/FnQnWTpgz0FOhU+Y1hkaAnVADNPX2rgtI O37Mb37R8oFRKwf9AesMR5U+nC1y10z0G9ba6ER6NU010+4tut3p2Tyit X-Google-Smtp-Source: AGHT+IFOh2GnWE2Fc4mkohprUWPhu64T3O26zygTZbKC+3ebA83Fv9+zbu+AQRGqoCzmHKD2yQx5gA== X-Received: by 2002:a05:600c:1e8c:b0:45b:47e1:ef6a with SMTP id 5b1f17b1804b1-45ddded5aaamr156724495e9.37.1757571749699; Wed, 10 Sep 2025 23:22:29 -0700 (PDT) Received: from [10.221.203.56] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e015621a3sm8402715e9.0.2025.09.10.23.22.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 23:22:29 -0700 (PDT) Message-ID: <121a7d8d-6918-452d-9d81-413a54d743bc@gmail.com> Date: Thu, 11 Sep 2025 09:22:28 +0300 Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net/mlx5: Not returning mlx5_link_info table when speed is unknown To: Li Tian , netdev@vger.kernel.org, linux-hyperv@vger.kernel.org Cc: Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Haiyang Zhang , Benjamin Poirier , Vitaly Kuznetsov , Carolina Jubran , Shahar Shitrit References: <20250910003732.5973-1-litian@redhat.com> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20250910003732.5973-1-litian@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/09/2025 3:37, Li Tian wrote: > Because mlx5e_link_info and mlx5e_ext_link_info have holes > e.g. Azure mlx5 reports PTYS 19. Do not return it unless speed > is retrieved successfully. > > Fixes: 65a5d35571849 ("net/mlx5: Refactor link speed handling with mlx5_link_info struct") > Suggested-by: Vitaly Kuznetsov > Signed-off-by: Li Tian > --- > v2: > - Fix indentation and spacing only. > v1: https://lore.kernel.org/netdev/20250908085313.18768-1-litian@redhat.com > --- > drivers/net/ethernet/mellanox/mlx5/core/port.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c > index 2d7adf7444ba..aa9f2b0a77d3 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/port.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c > @@ -1170,7 +1170,11 @@ const struct mlx5_link_info *mlx5_port_ptys2info(struct mlx5_core_dev *mdev, > mlx5e_port_get_link_mode_info_arr(mdev, &table, &max_size, > force_legacy); > i = find_first_bit(&temp, max_size); > - if (i < max_size) > + > + /* mlx5e_link_info has holes. Check speed > + * is not zero as indication of one. > + */ > + if (i < max_size && table[i].speed) > return &table[i]; > > return NULL; Reviewed-by: Tariq Toukan Thanks.