From: Naman Jain <namjain@linux.microsoft.com>
To: mhklinux@outlook.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, corbet@lwn.net, skhan@linuxfoundation.org,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/1] Documentation: hyperv: Update documentation for sending VMBus packets
Date: Tue, 13 Oct 2026 14:11:33 +0530 [thread overview]
Message-ID: <14013a11-b9e4-4cf9-b4ff-3253d179c991@linux.microsoft.com> (raw)
In-Reply-To: <20261013014354.18023-1-mhklinux@outlook.com>
On 10/13/2026 7:13 AM, Michael Kelley wrote:
> The functions for sending VMBus packets have changed.
> vmbus_sendpacket_mpb_desc() can target multiple ranges, and
> vmbus_sendpacket_pagebuffer() has been removed. vmbus_sendpacket_getid()
> has been added. Update the documentation accordingly.
>
> Fixes: 45a442fe369e ("Drivers: hv: vmbus: Remove vmbus_sendpacket_pagebuffer()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> ---
> Changes in v3:
> * Fixed typo in the documentation text [Sashiko]
>
> Changes in v2:
> * Add vmbus_sendpacket_getid() to the documentation. [Naman Jain]
>
> Documentation/virt/hyperv/vmbus.rst | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/virt/hyperv/vmbus.rst b/Documentation/virt/hyperv/vmbus.rst
> index 654bb4849972..c546e821ce6b 100644
> --- a/Documentation/virt/hyperv/vmbus.rst
> +++ b/Documentation/virt/hyperv/vmbus.rst
> @@ -141,14 +141,15 @@ Three functions exist to send VMBus channel messages:
>
> 1. vmbus_sendpacket(): Control-only messages and messages with
> embedded data -- no GPAs
> -2. vmbus_sendpacket_pagebuffer(): Message with list of GPAs
> - identifying data to transfer. An offset and length is
> - associated with each GPA so that multiple discontinuous areas
> - of guest memory can be targeted.
> -3. vmbus_sendpacket_mpb_desc(): Message with list of GPAs
> - identifying data to transfer. A single offset and length is
> - associated with a list of GPAs. The GPAs must describe a
> - single logical area of guest memory to be targeted.
> +2. vmbus_sendpacket_getid(): Similar to vmbus_sendpacket() but returns
> + a transaction ID that is matched against a reply from the Hyper-V
> + host. Useful when the struct completion (or other rendezvous data)
> + must reside on the caller's stack. By invalidating the transaction
> + ID before exiting the function due to a timeout or other error, a
> + late arriving interrupt is assured to not trash the stack.
> +3. vmbus_sendpacket_mpb_desc(): Message with one or more data ranges
> + to target. Each range consists of a single offset and length plus
> + a list of GPAs that describe a logical area of guest memory.
>
> Historically, Linux guests have trusted Hyper-V to send well-formed
> and valid messages, and Linux drivers for synthetic devices did not
We can retain the review tags for minor edits.
Reviewed-by: Naman Jain <namjain@linux.microsoft.com>
Regards,
Naman
next prev parent reply other threads:[~2026-10-13 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 1:43 [PATCH v3 1/1] Documentation: hyperv: Update documentation for sending VMBus packets Michael Kelley
2026-10-13 8:41 ` Naman Jain [this message]
2026-10-13 14:23 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14013a11-b9e4-4cf9-b4ff-3253d179c991@linux.microsoft.com \
--to=namjain@linux.microsoft.com \
--cc=corbet@lwn.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox