From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F55C19F2D for ; Tue, 9 Aug 2022 19:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345530AbiHITOW (ORCPT ); Tue, 9 Aug 2022 15:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345496AbiHITNw (ORCPT ); Tue, 9 Aug 2022 15:13:52 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88FD3396; Tue, 9 Aug 2022 12:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6RIQ0lsH7SzTIzVp99WDyc0D2gkpsha+DsfnlWOGmVM=; b=LbwWnCn7YGFZiUHtA5VIw6zpjm AI4mTSD37n0b+CjaKxm9C1z3JcyfcJa1xhHSXDPMhZurSkjfeBvuXCIVD/SZflQ49goPyxACJsmk4 Dve4XzeAnEBNetq25XCzE1veKxNwbMWFW+GqNs2gPkQS+A2YDL8lqgY20qLY6DJMYqY5qt1iIye1L w93yio6Gi+O8OzmpdNqTFBOanaijVaqR/f2QxYUcY5Ud7iO1du5dwk6YpZ/gEzvGMAAoybCw5fLlE c8X+2yQ2cyaRreWixWoiOwgjg2500HTd/KjIo0JJ24feOWMpq3WKTu1dac5fHfXnhgAifAi6cJoKB BZyKmvhw==; Received: from [187.56.70.103] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oLUWY-003lox-0k; Tue, 09 Aug 2022 21:04:18 +0200 Message-ID: <15188cf2-a510-2725-0c6e-3c4b264714c5@igalia.com> Date: Tue, 9 Aug 2022 16:03:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 06/13] um: Improve panic notifiers consistency and ordering Content-Language: en-US To: Johannes Berg , kexec@lists.infradead.org, linux-um@lists.infradead.org Cc: pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Anton Ivanov , Richard Weinberger References: <20220719195325.402745-1-gpiccoli@igalia.com> <20220719195325.402745-7-gpiccoli@igalia.com> <5bbc4296-4858-d01c-0c76-09d942377ddf@igalia.com> <54cd8c11428db4c419edf2267db00ca10da7a178.camel@sipsolutions.net> From: "Guilherme G. Piccoli" In-Reply-To: <54cd8c11428db4c419edf2267db00ca10da7a178.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On 09/08/2022 15:09, Johannes Berg wrote: > [...] >>> V2: >>> - Kept the notifier header to avoid implicit usage - thanks >>> Johannes for the suggestion! >>> >>> arch/um/drivers/mconsole_kern.c | 7 +++---- >>> arch/um/kernel/um_arch.c | 8 ++++---- >>> 2 files changed, 7 insertions(+), 8 deletions(-) >>> [...] >> >> Hi Johannes, do you feel this one is good now, after your last review? >> Thanks in advance, >> > > Yeah, no objections, my previous comment was just a minor almost style > issue anyway. > > johannes Perfect, thank you! Let me take the opportunity to ask you something I'm asking all the maintainers involved here - do you prefer taking the patch through your tree, or to get it landed with the whole series, at once, from some maintainer? Cheers!