linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support
@ 2023-04-18  5:12 Saurabh Sengar
  2023-04-18  5:12 ` [PATCH 1/2] x86/init: Remove static for get/set_rtc_noop() Saurabh Sengar
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Saurabh Sengar @ 2023-04-18  5:12 UTC (permalink / raw)
  To: tglx, mingo, bp, dave.hansen, x86, hpa, kys, haiyangz, wei.liu,
	decui, tiala, mikelley, linux-kernel, linux-hyperv

[PATCH v5 0/5] Hyper-V VTL support is already applied, however
there are couple of kernel test bot warning reported. This patch
series on top of [PATCH v5 0/5] Hyper-V VTL support fixes these.
I expect them to be squash commit on respective patches.

The first patch is to fix 1/5 of the series:
https://lore.kernel.org/all/1681192532-15460-2-git-send-email-ssengar@linux.microsoft.com/
The second patch is to fix 3/5 of the series:
https://lore.kernel.org/all/1681192532-15460-4-git-send-email-ssengar@linux.microsoft.com/

Saurabh Sengar (2):
  x86/init: Remove static for get/set_rtc_noop()
  x86/hyperv: Allow hv_get_nmi_reason compilation irrespective of HYPERV
    config

 arch/x86/include/asm/mshyperv.h | 10 +++++-----
 arch/x86/kernel/x86_init.c      |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] x86/init: Remove static for get/set_rtc_noop()
  2023-04-18  5:12 [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Saurabh Sengar
@ 2023-04-18  5:12 ` Saurabh Sengar
  2023-04-18  5:12 ` [PATCH 2/2] x86/hyperv: Allow hv_get_nmi_reason compilation irrespective of HYPERV config Saurabh Sengar
  2023-04-18  9:33 ` [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Borislav Petkov
  2 siblings, 0 replies; 6+ messages in thread
From: Saurabh Sengar @ 2023-04-18  5:12 UTC (permalink / raw)
  To: tglx, mingo, bp, dave.hansen, x86, hpa, kys, haiyangz, wei.liu,
	decui, tiala, mikelley, linux-kernel, linux-hyperv

Remove static from get/set_rtc_noop() so that it can be accessed
outside of the file.

Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
---
 arch/x86/kernel/x86_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
index ecdeb0974a87..d82f4fa2f1bf 100644
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; }
 static void iommu_shutdown_noop(void) { }
 bool __init bool_x86_init_noop(void) { return false; }
 void x86_op_int_noop(int cpu) { }
-static int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; }
-static void get_rtc_noop(struct timespec64 *now) { }
+int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; }
+void get_rtc_noop(struct timespec64 *now) { }
 
 static __initconst const struct of_device_id of_cmos_match[] = {
 	{ .compatible = "motorola,mc146818" },
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] x86/hyperv: Allow hv_get_nmi_reason compilation irrespective of HYPERV config
  2023-04-18  5:12 [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Saurabh Sengar
  2023-04-18  5:12 ` [PATCH 1/2] x86/init: Remove static for get/set_rtc_noop() Saurabh Sengar
@ 2023-04-18  5:12 ` Saurabh Sengar
  2023-04-18  9:33 ` [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Borislav Petkov
  2 siblings, 0 replies; 6+ messages in thread
From: Saurabh Sengar @ 2023-04-18  5:12 UTC (permalink / raw)
  To: tglx, mingo, bp, dave.hansen, x86, hpa, kys, haiyangz, wei.liu,
	decui, tiala, mikelley, linux-kernel, linux-hyperv

Move hv_get_nmi_reason out of CONFIG_HYPERV guard, so that it can be
compiled irrespective of CONFIG_HYPERV enabled or not.

Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
---
 arch/x86/include/asm/mshyperv.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 71ed240ef66d..67f8386c1775 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -29,6 +29,11 @@ typedef int (*hyperv_fill_flush_list_func)(
 
 void hyperv_vector_handler(struct pt_regs *regs);
 
+static inline unsigned char hv_get_nmi_reason(void)
+{
+	return 0;
+}
+
 #if IS_ENABLED(CONFIG_HYPERV)
 extern int hyperv_init_cpuhp;
 
@@ -189,11 +194,6 @@ static inline struct hv_vp_assist_page *hv_get_vp_assist_page(unsigned int cpu)
 	return hv_vp_assist_page[cpu];
 }
 
-static inline unsigned char hv_get_nmi_reason(void)
-{
-	return 0;
-}
-
 void __init hyperv_init(void);
 void hyperv_setup_mmu_ops(void);
 void set_hv_tscchange_cb(void (*cb)(void));
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support
  2023-04-18  5:12 [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Saurabh Sengar
  2023-04-18  5:12 ` [PATCH 1/2] x86/init: Remove static for get/set_rtc_noop() Saurabh Sengar
  2023-04-18  5:12 ` [PATCH 2/2] x86/hyperv: Allow hv_get_nmi_reason compilation irrespective of HYPERV config Saurabh Sengar
@ 2023-04-18  9:33 ` Borislav Petkov
  2023-04-18 16:17   ` Wei Liu
  2 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2023-04-18  9:33 UTC (permalink / raw)
  To: Saurabh Sengar, wei.liu
  Cc: tglx, mingo, dave.hansen, x86, hpa, kys, haiyangz, decui, tiala,
	mikelley, linux-kernel, linux-hyperv

On Mon, Apr 17, 2023 at 10:12:39PM -0700, Saurabh Sengar wrote:
> [PATCH v5 0/5] Hyper-V VTL support is already applied, however
> there are couple of kernel test bot warning reported. This patch
> series on top of [PATCH v5 0/5] Hyper-V VTL support fixes these.
> I expect them to be squash commit on respective patches.

That was supposed to happen when applying those using -rc7 as a base.

Wei, what's up?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support
  2023-04-18  9:33 ` [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Borislav Petkov
@ 2023-04-18 16:17   ` Wei Liu
  2023-04-18 17:27     ` Wei Liu
  0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2023-04-18 16:17 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Saurabh Sengar, wei.liu, tglx, mingo, dave.hansen, x86, hpa, kys,
	haiyangz, decui, tiala, mikelley, linux-kernel, linux-hyperv

On Tue, Apr 18, 2023 at 11:33:21AM +0200, Borislav Petkov wrote:
> On Mon, Apr 17, 2023 at 10:12:39PM -0700, Saurabh Sengar wrote:
> > [PATCH v5 0/5] Hyper-V VTL support is already applied, however
> > there are couple of kernel test bot warning reported. This patch
> > series on top of [PATCH v5 0/5] Hyper-V VTL support fixes these.
> > I expect them to be squash commit on respective patches.
> 
> That was supposed to happen when applying those using -rc7 as a base.
> 
> Wei, what's up?

I did use -rc7 as the base. This is what is in hyperv-next right now.

https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?h=hyperv-next&id=25dcc7316ef7def25cdab3658ac665bf0ce0ddc5

I think Saurabh was responding to a report that was generated on his v5
series. I don't think the first patch is needed.

The second one is probably still needed.

Thanks,
Wei.

> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support
  2023-04-18 16:17   ` Wei Liu
@ 2023-04-18 17:27     ` Wei Liu
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2023-04-18 17:27 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Saurabh Sengar, wei.liu, tglx, mingo, dave.hansen, x86, hpa, kys,
	haiyangz, decui, tiala, mikelley, linux-kernel, linux-hyperv

On Tue, Apr 18, 2023 at 04:17:26PM +0000, Wei Liu wrote:
> On Tue, Apr 18, 2023 at 11:33:21AM +0200, Borislav Petkov wrote:
> > On Mon, Apr 17, 2023 at 10:12:39PM -0700, Saurabh Sengar wrote:
> > > [PATCH v5 0/5] Hyper-V VTL support is already applied, however
> > > there are couple of kernel test bot warning reported. This patch
> > > series on top of [PATCH v5 0/5] Hyper-V VTL support fixes these.
> > > I expect them to be squash commit on respective patches.
> > 
> > That was supposed to happen when applying those using -rc7 as a base.
> > 
> > Wei, what's up?
> 
> I did use -rc7 as the base. This is what is in hyperv-next right now.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/commit/?h=hyperv-next&id=25dcc7316ef7def25cdab3658ac665bf0ce0ddc5
> 
> I think Saurabh was responding to a report that was generated on his v5
> series. I don't think the first patch is needed.

Never mind, I think I messed up when applying Saurabh's patch. I will
fix the tree today.

Thanks,
Wei.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-04-18 17:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-18  5:12 [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Saurabh Sengar
2023-04-18  5:12 ` [PATCH 1/2] x86/init: Remove static for get/set_rtc_noop() Saurabh Sengar
2023-04-18  5:12 ` [PATCH 2/2] x86/hyperv: Allow hv_get_nmi_reason compilation irrespective of HYPERV config Saurabh Sengar
2023-04-18  9:33 ` [PATCH 0/2] Fix for applied series [PATCH v5 0/5] Hyper-V VTL support Borislav Petkov
2023-04-18 16:17   ` Wei Liu
2023-04-18 17:27     ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).