From: Saurabh Sengar <ssengar@linux.microsoft.com>
To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org
Cc: longli@microsoft.com, ssengar@microsoft.com
Subject: [PATCH v3 7/7] uio_hv_generic: Remove use of PAGE_SIZE
Date: Sat, 30 Mar 2024 01:52:03 -0700 [thread overview]
Message-ID: <1711788723-8593-8-git-send-email-ssengar@linux.microsoft.com> (raw)
In-Reply-To: <1711788723-8593-1-git-send-email-ssengar@linux.microsoft.com>
Remove use of PAGE_SIZE for device ring buffer size calculation, as
there is no dependency on device ring buffer size for linux kernel's
PAGE_SIZE. Use the absolute value of 2 MB instead.
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
---
drivers/uio/uio_hv_generic.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index 289611c7dfd7..015ddbddd6e1 100644
--- a/drivers/uio/uio_hv_generic.c
+++ b/drivers/uio/uio_hv_generic.c
@@ -36,7 +36,6 @@
#define DRIVER_AUTHOR "Stephen Hemminger <sthemmin at microsoft.com>"
#define DRIVER_DESC "Generic UIO driver for VMBus devices"
-#define HV_RING_SIZE 512 /* pages */
#define SEND_BUFFER_SIZE (16 * 1024 * 1024)
#define RECV_BUFFER_SIZE (31 * 1024 * 1024)
@@ -146,7 +145,7 @@ static const struct bin_attribute ring_buffer_bin_attr = {
.name = "ring",
.mode = 0600,
},
- .size = 2 * HV_RING_SIZE * PAGE_SIZE,
+ .size = 2 * SZ_2M,
.mmap = hv_uio_ring_mmap,
};
@@ -156,7 +155,7 @@ hv_uio_new_channel(struct vmbus_channel *new_sc)
{
struct hv_device *hv_dev = new_sc->primary_channel->device_obj;
struct device *device = &hv_dev->device;
- const size_t ring_bytes = HV_RING_SIZE * PAGE_SIZE;
+ const size_t ring_bytes = SZ_2M;
int ret;
/* Create host communication ring */
@@ -244,7 +243,7 @@ hv_uio_probe(struct hv_device *dev,
size_t ring_size = hv_dev_ring_size(channel);
if (!ring_size)
- ring_size = HV_RING_SIZE * PAGE_SIZE;
+ ring_size = SZ_2M;
pdata = devm_kzalloc(&dev->device, sizeof(*pdata), GFP_KERNEL);
if (!pdata)
--
2.34.1
prev parent reply other threads:[~2024-03-30 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 8:51 [PATCH v3 0/7] Low speed Hyper-V devices support Saurabh Sengar
2024-03-30 8:51 ` [PATCH v3 1/7] Drivers: hv: vmbus: Add utility function for querying ring size Saurabh Sengar
2024-03-30 8:51 ` [PATCH v3 2/7] uio_hv_generic: Query the ringbuffer size for device Saurabh Sengar
2024-03-30 8:51 ` [PATCH v3 3/7] uio_hv_generic: Enable interrupt for low speed VMBus devices Saurabh Sengar
2024-03-30 8:52 ` [PATCH v3 4/7] tools: hv: Add vmbus_bufring Saurabh Sengar
2024-03-30 8:52 ` [PATCH v3 5/7] tools: hv: Add new fcopy application based on uio driver Saurabh Sengar
2024-04-03 17:54 ` Long Li
2024-03-30 8:52 ` [PATCH v3 6/7] Drivers: hv: Remove fcopy driver Saurabh Sengar
2024-03-30 8:52 ` Saurabh Sengar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1711788723-8593-8-git-send-email-ssengar@linux.microsoft.com \
--to=ssengar@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=ssengar@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).