* [PATCH net-next] net: mana: Record doorbell physical address in PF mode
@ 2025-06-09 23:09 longli
2025-06-10 22:35 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: longli @ 2025-06-09 23:09 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Shradha Gupta, Simon Horman, Konstantin Taranov,
Souradeep Chakrabarti, Erick Archer, linux-hyperv, netdev,
linux-kernel, linux-rdma
Cc: Long Li
From: Long Li <longli@microsoft.com>
MANA supports RDMA in PF mode. The driver should record the doorbell
physical address when in PF mode.
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/ethernet/microsoft/mana/gdma_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
index 3504507477c6..52cf7112762c 100644
--- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
+++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
@@ -31,6 +31,9 @@ static void mana_gd_init_pf_regs(struct pci_dev *pdev)
gc->db_page_base = gc->bar0_va +
mana_gd_r64(gc, GDMA_PF_REG_DB_PAGE_OFF);
+ gc->phys_db_page_base = gc->bar0_pa +
+ mana_gd_r64(gc, GDMA_PF_REG_DB_PAGE_OFF);
+
sriov_base_off = mana_gd_r64(gc, GDMA_SRIOV_REG_CFG_BASE_OFF);
sriov_base_va = gc->bar0_va + sriov_base_off;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mana: Record doorbell physical address in PF mode
2025-06-09 23:09 [PATCH net-next] net: mana: Record doorbell physical address in PF mode longli
@ 2025-06-10 22:35 ` Jakub Kicinski
2025-06-10 23:43 ` [EXTERNAL] " Long Li
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-06-10 22:35 UTC (permalink / raw)
To: longli
Cc: longli, K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Paolo Abeni, Shradha Gupta,
Simon Horman, Konstantin Taranov, Souradeep Chakrabarti,
Erick Archer, linux-hyperv, netdev, linux-kernel, linux-rdma
On Mon, 9 Jun 2025 16:09:40 -0700 longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> MANA supports RDMA in PF mode. The driver should record the doorbell
> physical address when in PF mode.
Could you explain in more detail what happens if it doesn't?
What user-visible improvement does this patch bring?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXTERNAL] Re: [PATCH net-next] net: mana: Record doorbell physical address in PF mode
2025-06-10 22:35 ` Jakub Kicinski
@ 2025-06-10 23:43 ` Long Li
0 siblings, 0 replies; 3+ messages in thread
From: Long Li @ 2025-06-10 23:43 UTC (permalink / raw)
To: Jakub Kicinski, longli@linuxonhyperv.com
Cc: KY Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui,
David S. Miller, Eric Dumazet, Paolo Abeni, Shradha Gupta,
Simon Horman, Konstantin Taranov, Souradeep Chakrabarti,
Erick Archer, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net-next] net: mana: Record doorbell physical
> address in PF mode
>
> On Mon, 9 Jun 2025 16:09:40 -0700 longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > MANA supports RDMA in PF mode. The driver should record the doorbell
> > physical address when in PF mode.
>
> Could you explain in more detail what happens if it doesn't?
> What user-visible improvement does this patch bring?
Yes, I'm sending v2 with more details in the commit message.
> --
> pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-10 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-09 23:09 [PATCH net-next] net: mana: Record doorbell physical address in PF mode longli
2025-06-10 22:35 ` Jakub Kicinski
2025-06-10 23:43 ` [EXTERNAL] " Long Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).