Re: [PATCH v6 0/5] Allow dyn MSI-X vector allocation of MANA

Shradha Gupta
2025-06-17T10:53:34Z

On Mon, Jun 16, 2025 at 06:11:48PM -0700, Jakub Kicinski wrote:
> On Wed, 11 Jun 2025 23:10:55 -0700 Shradha Gupta wrote:
> > On Wed, Jun 11, 2025 at 08:54:16AM -0700, Jakub Kicinski wrote:
> > > On Wed, 11 Jun 2025 07:09:44 -0700 Shradha Gupta wrote:
> > > > Changes in v6
> > > > * rebased to linux-next's v6.16-rc1 as per Jakub's suggestion
> > >
> > > I meant a branch, basically apply the patches on the v6.16-rc1 tag
> > > and push it out to GitHub, kernel.org or somewhere else public.
> > > Then we can pull it in and maintain the stable commit IDs.
> > > No need to repost the patches, FWIW, just share the branch here
> > > once you pushed it out..
> >
> > Oh, understood. Thanks for the clarity. Here is a github repo branch
> > with the changes on v6.16-rc1 tag
> > https://github.com/shradhagupta6/linux/tree/shradha_v6.16-rc1
>
> The tag was good, but when I pulled it my check scripts complained:
>
> Commit a19036b86845 ("net: mana: Allocate MSI-X vectors dynamically")
> committer Signed-off-by missing
> author email: shradhagupta@linux.microsoft.com
> committer email: shradhagupta@microsoft.com
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
>
> etc. You seem to have committed the patches with a slightly different
> email address. Not a huge deal but better to fix it if we can.
>
> So please base the tag. The code can stay the same just adjust the
> committer or author/signoff email addrs. We can use this as an
> opportunity to add Bjorn's email.
>
> No need to repost the code just ping here once you updated the tag.

Hi Jakub,

I have updated the tag with the corrected author and committer details
and added Bjorn's ack:
https://github.com/shradhagupta6/linux/tree/shradha_v6.16-rc1

By 'please base the tag', did you mean we rebase the changes with rc2?
If so, I have also created a rc2 tag branch, JFYI
https://github.com/shradhagupta6/linux/tree/shradha_v6.16-rc2

Hope this helps.

Thanks,
Shradha.