* [PATCH] hv/hv_kvp_daemon: Prevent similar logs in kvp_key_add_or_modify()
@ 2025-06-19 5:26 Shradha Gupta
2025-07-09 22:45 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Shradha Gupta @ 2025-06-19 5:26 UTC (permalink / raw)
To: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui, Naman Jain,
linux-hyperv, linux-kernel
Cc: Shradha Gupta, Shradha Gupta
When hv_kvp_daemon is started in debug mode, in function
kvp_key_add_or_modify() too many similar logs are logged for
key/value being too long.
Restructured the logs to prevent this extra logging
Suggested-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
---
tools/hv/hv_kvp_daemon.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 1f64c680be13..91a708282358 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -352,21 +352,17 @@ static int kvp_key_add_or_modify(int pool, const __u8 *key, int key_size,
int num_blocks;
int i;
- if (debug)
- syslog(LOG_DEBUG, "%s: got a KVP: pool=%d key=%s val=%s",
- __func__, pool, key, value);
-
if ((key_size > HV_KVP_EXCHANGE_MAX_KEY_SIZE) ||
(value_size > HV_KVP_EXCHANGE_MAX_VALUE_SIZE)) {
- syslog(LOG_ERR, "%s: Too long key or value: key=%s, val=%s",
- __func__, key, value);
-
- if (debug)
- syslog(LOG_DEBUG, "%s: Too long key or value: pool=%d, key=%s, val=%s",
- __func__, pool, key, value);
+ syslog(LOG_ERR, "%s: Too long key or value: pool=%d key=%s, val=%s",
+ __func__, pool, key, value);
return 1;
}
+ if (debug)
+ syslog(LOG_DEBUG, "%s: got a KVP: pool=%d key=%s val=%s",
+ __func__, pool, key, value);
+
/*
* First update the in-memory state.
*/
base-commit: 4325743c7e209ae7845293679a4de94b969f2bef
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hv/hv_kvp_daemon: Prevent similar logs in kvp_key_add_or_modify()
2025-06-19 5:26 [PATCH] hv/hv_kvp_daemon: Prevent similar logs in kvp_key_add_or_modify() Shradha Gupta
@ 2025-07-09 22:45 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2025-07-09 22:45 UTC (permalink / raw)
To: Shradha Gupta
Cc: K. Y. Srinivasan, Haiyang Zhang, Wei Liu, Dexuan Cui, Naman Jain,
linux-hyperv, linux-kernel, Shradha Gupta
On Wed, Jun 18, 2025 at 10:26:01PM -0700, Shradha Gupta wrote:
> When hv_kvp_daemon is started in debug mode, in function
> kvp_key_add_or_modify() too many similar logs are logged for
> key/value being too long.
>
> Restructured the logs to prevent this extra logging
>
> Suggested-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Applied to hyperv-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-09 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-19 5:26 [PATCH] hv/hv_kvp_daemon: Prevent similar logs in kvp_key_add_or_modify() Shradha Gupta
2025-07-09 22:45 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).