linux-hyperv.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	mhklinux@outlook.com, decui@microsoft.com,
	paekkaladevi@linux.microsoft.com,
	Nuno Das Neves <nunodasneves@linux.microsoft.com>
Subject: [PATCH 1/6] mshv: Only map vp->vp_stats_pages if on root scheduler
Date: Thu, 28 Aug 2025 17:43:45 -0700	[thread overview]
Message-ID: <1756428230-3599-2-git-send-email-nunodasneves@linux.microsoft.com> (raw)
In-Reply-To: <1756428230-3599-1-git-send-email-nunodasneves@linux.microsoft.com>

This mapping is only used for checking if the dispatch thread is
blocked. This is only relevant for the root scheduler, so check the
scheduler type to determine whether to map/unmap these pages, instead of
the current check, which is incorrect.

Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
---
 drivers/hv/mshv_root_main.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c
index e4ee9beddaf5..bbdefe8a2e9c 100644
--- a/drivers/hv/mshv_root_main.c
+++ b/drivers/hv/mshv_root_main.c
@@ -987,7 +987,11 @@ mshv_partition_ioctl_create_vp(struct mshv_partition *partition,
 			goto unmap_register_page;
 	}
 
-	if (hv_parent_partition()) {
+	/*
+	 * This mapping of the stats page is for detecting if dispatch thread
+	 * is blocked - only relevant for root scheduler
+	 */
+	if (hv_scheduler_type == HV_SCHEDULER_TYPE_ROOT) {
 		ret = mshv_vp_stats_map(partition->pt_id, args.vp_index,
 					stats_pages);
 		if (ret)
@@ -1016,7 +1020,7 @@ mshv_partition_ioctl_create_vp(struct mshv_partition *partition,
 	if (mshv_partition_encrypted(partition) && is_ghcb_mapping_available())
 		vp->vp_ghcb_page = page_to_virt(ghcb_page);
 
-	if (hv_parent_partition())
+	if (hv_scheduler_type == HV_SCHEDULER_TYPE_ROOT)
 		memcpy(vp->vp_stats_pages, stats_pages, sizeof(stats_pages));
 
 	/*
@@ -1039,7 +1043,7 @@ mshv_partition_ioctl_create_vp(struct mshv_partition *partition,
 free_vp:
 	kfree(vp);
 unmap_stats_pages:
-	if (hv_parent_partition())
+	if (hv_scheduler_type == HV_SCHEDULER_TYPE_ROOT)
 		mshv_vp_stats_unmap(partition->pt_id, args.vp_index);
 unmap_ghcb_page:
 	if (mshv_partition_encrypted(partition) && is_ghcb_mapping_available()) {
@@ -1793,7 +1797,7 @@ static void destroy_partition(struct mshv_partition *partition)
 			if (!vp)
 				continue;
 
-			if (hv_parent_partition())
+			if (hv_scheduler_type == HV_SCHEDULER_TYPE_ROOT)
 				mshv_vp_stats_unmap(partition->pt_id, vp->vp_index);
 
 			if (vp->vp_register_page) {
-- 
2.34.1


  reply	other threads:[~2025-08-29  0:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29  0:43 [PATCH 0/6] mshv: Fixes for stats and vp state page mappings Nuno Das Neves
2025-08-29  0:43 ` Nuno Das Neves [this message]
2025-09-04 17:00   ` [PATCH 1/6] mshv: Only map vp->vp_stats_pages if on root scheduler Anirudh Rayabharam
2025-09-05 15:20   ` Praveen K Paladugu
2025-09-05 19:43   ` Easwar Hariharan
2025-09-06  7:11   ` Tianyu Lan
2025-08-29  0:43 ` [PATCH 2/6] mshv: Ignore second stats page map result failure Nuno Das Neves
2025-09-05 15:31   ` Praveen K Paladugu
2025-09-05 18:48     ` Nuno Das Neves
2025-09-05 19:21   ` Easwar Hariharan
2025-09-08 17:04     ` Nuno Das Neves
2025-09-08 17:22       ` Easwar Hariharan
2025-09-08 18:06         ` Nuno Das Neves
2025-09-09 14:52           ` Praveen K Paladugu
2025-09-09 16:27             ` Easwar Hariharan
2025-09-09 17:31               ` Nuno Das Neves
2025-09-06 17:30   ` Tianyu Lan
2025-08-29  0:43 ` [PATCH 3/6] mshv: Add the HVCALL_GET_PARTITION_PROPERTY_EX hypercall Nuno Das Neves
2025-09-04 17:12   ` Anirudh Rayabharam
2025-09-05 15:40   ` Praveen K Paladugu
2025-09-05 19:28   ` Easwar Hariharan
2025-09-05 23:13     ` Nuno Das Neves
2025-08-29  0:43 ` [PATCH 4/6] mshv: Get the vmm capabilities offered by the hypervisor Nuno Das Neves
2025-09-05 15:43   ` Praveen K Paladugu
2025-09-05 18:49     ` Nuno Das Neves
2025-09-05 19:03   ` Anirudh Rayabharam
2025-09-05 23:07     ` Nuno Das Neves
2025-09-05 19:29   ` Easwar Hariharan
2025-09-06 17:34   ` Tianyu Lan
2025-08-29  0:43 ` [PATCH 5/6] mshv: Allocate vp state page for HVCALL_MAP_VP_STATE_PAGE on L1VH Nuno Das Neves
2025-09-05 16:18   ` Praveen K Paladugu
2025-09-05 19:41   ` Easwar Hariharan
2025-08-29  0:43 ` [PATCH 6/6] mshv: Introduce new hypercall to map stats page for L1VH partitions Nuno Das Neves
2025-09-05 19:50   ` Easwar Hariharan
2025-09-05 23:12     ` Nuno Das Neves
2025-09-08 16:26       ` Easwar Hariharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1756428230-3599-2-git-send-email-nunodasneves@linux.microsoft.com \
    --to=nunodasneves@linux.microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=paekkaladevi@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).