From: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
To: wei.liu@kernel.org
Cc: easwar.hariharan@linux.microsoft.com,
"Linux on Hyper-V List" <linux-hyperv@vger.kernel.org>,
"Doru Blânzeanu" <dblanzeanu@linux.microsoft.com>,
"Magnus Kulke" <magnuskulke@linux.microsoft.com>,
stable@kernel.org, "K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Long Li" <longli@microsoft.com>,
"Nuno Das Neves" <nunodasneves@linux.microsoft.com>,
"Roman Kisel" <romank@linux.microsoft.com>,
"Michael Kelley" <mhklinux@outlook.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mshv: add a missing padding field
Date: Thu, 23 Apr 2026 10:32:58 -0700 [thread overview]
Message-ID: <19a904f4-e26f-4951-85ac-aae537da89cb@linux.microsoft.com> (raw)
In-Reply-To: <614f1e17-2dba-4529-b067-e1434b74cad8@linux.microsoft.com>
On 4/23/2026 10:29 AM, Easwar Hariharan wrote:
> On 4/23/2026 10:26 AM, wei.liu@kernel.org wrote:
>> From: Wei Liu <wei.liu@kernel.org>
>>
>> That was missed when importing the header.
>>
>> Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
>> Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
>> Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
>> Cc: stable@kernel.org
>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>> ---
>> include/hyperv/hvhdk.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
>> index 5e83d3714966..ff7ca9ee1bd4 100644
>> --- a/include/hyperv/hvhdk.h
>> +++ b/include/hyperv/hvhdk.h
>> @@ -79,6 +79,7 @@ struct hv_vp_register_page {
>>
>> u64 registers[18];
>> };
>> + __u8 reserved[8];
>> /* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
>> union {
>> struct {
>
>
> This is not a uapi, so why not just use u8 instead of __u8?
> Or since it's 8 u8s, a u64?
>
> Thanks,
> Easwar (he/him)
Hm, occurs to me that this would be used by VMMs, but then the registers
field just above used a u64 instead of a __u64....
next prev parent reply other threads:[~2026-04-23 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 17:26 [PATCH] mshv: add a missing padding field wei.liu
2026-04-23 17:29 ` Easwar Hariharan
2026-04-23 17:32 ` Easwar Hariharan [this message]
2026-04-23 18:14 ` Wei Liu
2026-04-23 18:16 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a904f4-e26f-4951-85ac-aae537da89cb@linux.microsoft.com \
--to=easwar.hariharan@linux.microsoft.com \
--cc=dblanzeanu@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=magnuskulke@linux.microsoft.com \
--cc=mhklinux@outlook.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=romank@linux.microsoft.com \
--cc=stable@kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox