From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@microsoft.com, linux-hyperv@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL v3] Hyper-V commits for 5.0-rc
Date: Sun, 24 Feb 2019 09:17:10 +0100 [thread overview]
Message-ID: <20190224081710.GA23894@kroah.com> (raw)
In-Reply-To: <20190223155533.GE10616@sasha-vm>
On Sat, Feb 23, 2019 at 10:55:33AM -0500, Sasha Levin wrote:
> On Sat, Feb 23, 2019 at 09:57:15AM +0100, Greg KH wrote:
> > On Fri, Feb 22, 2019 at 10:12:25PM -0500, Sasha Levin wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > >
> > > The following changes since commit 8834f5600cf3c8db365e18a3d5cac2c2780c81e5:
> > >
> > > Linux 5.0-rc5 (2019-02-03 13:48:04 -0800)
> > >
> > > are available in the Git repository at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git tags/hyperv-fixes-signed
> > >
> > > for you to fetch changes up to b2946cd86f3c1b5b1262c0ec06068110c2328fe6:
> > >
> > > MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS (2019-02-22 21:46:37 -0500)
> > >
> > > - ----------------------------------------------------------------
> > > Two fixes:
> > >
> > > 1. A fix for a race condition reading sysfs entries while a device is
> > > being added, by Kimberly Brown.
> > >
> > > 2. Update the Hyper-V mailing list to a new one created on
> > > vger.kernel.org, by Haiyang Zhang.
> > >
> > > - ----------------------------------------------------------------
> > > Haiyang Zhang (1):
> > > MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS
> > >
> > > Kimberly Brown (2):
> > > Drivers: hv: vmbus: Change server monitor_pages index to 0
> > > Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set
> >
> > I objected to this last patch when it was posted on the list. The sysfs
> > file should just not be present if the functionality is not there, no
> > need to add the "-EINVAL" logic to it instead.
> >
> > Having a sysfs file that says it can be read, and then rejecting that
> > read with an error is NOT ok.
>
> Hm, I'm sorry but I didn't see an objection on the thread
> (https://lore.kernel.org/lkml/20190122020759.GA4054@ubu-Virtual-Machine/)
> which is why it was sent in like this.
>
> Could you please point me to it so we can get the patch fixed up?
My response was Message-ID: <20190219061748.GA5819@kroah.com> sent:
Date: Tue, 19 Feb 2019 07:17:48 +0100
but for some reason I do not see it on lore.kernel.org at all :(
I don't know what happened to it, sorry, it was also cc: to you.
Anyway, it just said what I said here, don't do this type of thing, if
the sysfs file is not valid for a specific device, just do not create
it, do not mess around with returning error values when trying to read
from it.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-24 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 3:12 [GIT PULL v3] Hyper-V commits for 5.0-rc Sasha Levin
2019-02-23 8:57 ` Greg KH
2019-02-23 15:55 ` Sasha Levin
2019-02-23 16:47 ` Kimberly Brown
2019-02-23 17:14 ` Sasha Levin
2019-02-24 8:17 ` Greg KH [this message]
2019-02-24 17:37 ` Kimberly Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224081710.GA23894@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).