From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D35C43381 for ; Tue, 12 Mar 2019 05:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B12FD2084F for ; Tue, 12 Mar 2019 05:02:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="BGWYUwch" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfCLFCM (ORCPT ); Tue, 12 Mar 2019 01:02:12 -0400 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:47538 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbfCLFCM (ORCPT ); Tue, 12 Mar 2019 01:02:12 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 080369E6 for ; Tue, 12 Mar 2019 05:02:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9xAnekmfWJYs for ; Tue, 12 Mar 2019 00:02:10 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id D139E975 for ; Tue, 12 Mar 2019 00:02:10 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id p143so937898iod.19 for ; Mon, 11 Mar 2019 22:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=GfdWM9SSU7KfpdKIZzPpOpuTjbGIrvUY//TTRkRyo1k=; b=BGWYUwchhNVeCgZBoDBH4UKpaQr5T0h/RgqAWCNl/5B0vE8wmK9V3uDs4mQCMyM2Dw hlrYClNJE3J1YsOfT/SxnI+c+Ct9QRroNMaoIKI4Vk9w391yIwAZhAe6KY7IfpAqRgjV v8JKG1+vAztwb6UxUxiiGfxm+Gv/RmJfPi2CSYjMjtStawpQxBSR3o2zC8mIcF93JopG yO7j54hOjWUMz/lf1YXZnnDR8vlqyMt6dbS0pvm/ATzoU2An+JXUFehfBV09pUv71RPh 3CxM0iP2/IBnegfxtgOawVUo2GlL6zmlG7zUPngNKbn27i1n7UGcvzPxXa+K7ZJZ+rK2 FYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GfdWM9SSU7KfpdKIZzPpOpuTjbGIrvUY//TTRkRyo1k=; b=W9ZlSydZnVHPblcMeUoy+1HPzesXbEESHe3XqGCZqKUjl3eXVVvsC+9hZPsNhwjziq TqxZMXaJ5ZoBrM00uEi701lq3viU5XbBwZdI0TsgPekBLyfDHmFhg1mY8gCmrrH9STDx 9TqwRhU2MjnKKKW/5GF4I8mrreK5GEzIG8SKKlgExMRXkIqLzhLXm4WyCdsmmxRscuFO aJQqKDfeQN+f0jup7XxaF0A8vHKU6PRR3Gaml5jsiGGtTyAOSqGJM0O7/CTc3VbZRDbv jxPg01MK1nR6uA5Yb+tV/ZXpJnWrU7cQINqE09rAhRUFQuECvBHQv5LJfyu5lNSm3AvZ sguA== X-Gm-Message-State: APjAAAWfu3q4hiDMXyGkzZXylCHAwZvT275+AOPDvZjBwB9fweZ1wOg2 AQlwjG/rGqyk5wRKm8yaA7X09DqLuTVQ+8duDOT3zX/t3PMh+DohKNQeDRGEr7dwTGAJfs+IWLm YukwSriwHbOezNtmEntuBTNAX6CEb X-Received: by 2002:a02:85ec:: with SMTP id d99mr11811785jai.116.1552366930468; Mon, 11 Mar 2019 22:02:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxslqLpIgRl8QFYE5oUsL0JMPs46bt4QOb6Wyfx39EPkn4L1aPkB54MDW4k2WFHG2cSAulelA== X-Received: by 2002:a02:85ec:: with SMTP id d99mr11811778jai.116.1552366930212; Mon, 11 Mar 2019 22:02:10 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id e11sm3170229iog.79.2019.03.11.22.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 22:02:09 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Sasha Levin , "David S. Miller" , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] hv_netvsc: fix a possible NULL pointer dereference in netvsc_get_ethtool_stats() Date: Tue, 12 Mar 2019 00:01:49 -0500 Message-Id: <20190312050149.3032-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org In case kvmalloc_array fails, we should stop using it to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/net/hyperv/netvsc_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index cf4897043e83..4b3a03029fe8 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -1426,6 +1426,9 @@ static void netvsc_get_ethtool_stats(struct net_device *dev, pcpu_sum = kvmalloc_array(num_possible_cpus(), sizeof(struct netvsc_ethtool_pcpu_stats), GFP_KERNEL); + if (!pcpu_sum) + return; + netvsc_get_pcpu_stats(dev, pcpu_sum); for_each_present_cpu(cpu) { struct netvsc_ethtool_pcpu_stats *this_sum = &pcpu_sum[cpu]; -- 2.17.1