From: Branden Bonaby <brandonbonaby94@gmail.com>
To: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, sashal@kernel.org
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] drivers: hv: vmbus: add test attributes to debugfs
Date: Tue, 20 Aug 2019 14:17:54 -0400 [thread overview]
Message-ID: <20190820181754.GA23739@Test-Virtual-Machine> (raw)
In-Reply-To: <e055f27ffc37a9a6a756a3329a60da608db5a04f.1566266609.git.brandonbonaby94@gmail.com>
On Mon, Aug 19, 2019 at 10:44:48PM -0400, Branden Bonaby wrote:
> Expose the test parameters as part of the debugfs channel attributes.
> We will control the testing state via these attributes.
>
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
> Changes in v2:
> - Move test attributes to debugfs.
> - Wrap test code under #ifdef statements.
> - Add new documentation file under Documentation/ABI/testing.
> - Make commit message reflect the change from from sysfs to debugfs.
>
>
> + if (IS_ERR_OR_NULL(dev_root)) {
> + pr_debug("debugfs_hyperv: %s/%s/ not created\n",
> + TESTING, device);
> + return PTR_ERR(dev_root);
> + }
Whoops, that single IS_ERR_OR_NULL shouldn't be there, it should just
be IS_ERR I'll change and resend the patch.
next prev parent reply other threads:[~2019-08-20 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 2:44 [PATCH v2 0/3] hv: vmbus: add fuzz testing to hv device Branden Bonaby
2019-08-20 2:44 ` [PATCH v2 1/3] drivers: hv: vmbus: Introduce latency testing Branden Bonaby
2019-08-21 22:52 ` Michael Kelley
2019-08-23 3:38 ` Branden Bonaby
2019-08-23 16:44 ` Michael Kelley
2019-08-23 17:36 ` Branden Bonaby
2019-08-20 2:44 ` [PATCH v2 2/3] drivers: hv: vmbus: add test attributes to debugfs Branden Bonaby
2019-08-20 18:17 ` Branden Bonaby [this message]
2019-08-20 2:45 ` [PATCH v2 3/3] tools: hv: add vmbus testing tool Branden Bonaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820181754.GA23739@Test-Virtual-Machine \
--to=brandonbonaby94@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).