From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC50C47404 for ; Fri, 4 Oct 2019 15:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73A8921D81 for ; Fri, 4 Oct 2019 15:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570203978; bh=RtSEgS9Ir5OhXsBQuEonT/del/hDREk1xI0g6Q4VtDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wn8pN3XaZVc73SoX/jrcQG6gIOUAC3FyHKCGGVPl8NIEE8/p66OCcIyfGnMrgStO5 zoLkToeseEO+kxmRQtcu1bEbKpQr4PVEQOrO0luajKliZwWWp5NQNpB4qJycBG4sg0 TKcn7RJ4x44xX2DBTPG9xDlcM1rVvjLH/Z7O6vIA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390005AbfJDPqS (ORCPT ); Fri, 4 Oct 2019 11:46:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:36470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389952AbfJDPqS (ORCPT ); Fri, 4 Oct 2019 11:46:18 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2C0620830; Fri, 4 Oct 2019 15:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570203977; bh=RtSEgS9Ir5OhXsBQuEonT/del/hDREk1xI0g6Q4VtDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rZVxQVRpDReG0V6jQUbrt9ODsMJ7hGNR1UpN39oTXrVtvT70zLAw7bDg89/C8wa8e Q5wKW2ggEuEoE9rmgkQ+E70WEy40QxCIbhIFAchIWO9qdn0jnVN8g694FQzMxe5vd+ iVyXu0GmxSGV93WkricbtkNeTGePfp4aE7QVwlp8= Date: Fri, 4 Oct 2019 11:46:15 -0400 From: Sasha Levin To: Michael Kelley Cc: Himadri Pandya , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "tglx@linutronix.de" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "himadri18.07" Subject: Re: [PATCH] Drivers: hv: balloon: Remove dependencies on guest page size Message-ID: <20191004154615.GK17454@sasha-vm> References: <20190817040850.4812-1-himadri18.07@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Sep 04, 2019 at 11:37:12PM +0000, Michael Kelley wrote: >From: Himadri Pandya Sent: Friday, August 16, 2019 9:09 PM >> >> Hyper-V assumes page size to be 4K. This might not be the case for >> ARM64 architecture. Hence use hyper-v specific page size and page >> shift definitions to avoid conflicts between different host and guest >> page sizes on ARM64. >> >> Also, remove some old and incorrect comments and redefine ballooning >> granularities to handle larger page sizes correctly. >> >> Signed-off-by: Himadri Pandya >> --- >> drivers/hv/hv_balloon.c | 25 ++++++++++++------------- >> 1 file changed, 12 insertions(+), 13 deletions(-) >> > >Reviewed-by: Michael Kelley > >Thomas -- can you pick up this patch in the x86/hyperv branch of your >tip tree along with the other patches to fix wrong page size assumptions? I've queued this for hyperv-next, thanks! -- Thanks, Sasha