From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E32C4360C for ; Tue, 8 Oct 2019 16:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82F3B20815 for ; Tue, 8 Oct 2019 16:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570551007; bh=/BoU6dCrW2ZJVVBvlhQ/XO4zzu0SGfE9FJr2hYf1sfs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bjEpfAaA6TufhSIatvz66vQydqxGq4/jadXAwPcN9W2DYVX2GcZrXMvgYrvCIRHxr 2PR0OwFdatw6birWDbnnkG5cBwjSi5SdQEdWDaX320Po/Sox5253V/yqOWIDNBlLx5 YJfi86CN2up1ilr5H2YP+216tGigAma94+YcJijA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbfJHQKH (ORCPT ); Tue, 8 Oct 2019 12:10:07 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39453 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbfJHQKH (ORCPT ); Tue, 8 Oct 2019 12:10:07 -0400 Received: by mail-wr1-f67.google.com with SMTP id r3so20116293wrj.6; Tue, 08 Oct 2019 09:10:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TwO+d9qD9wJW979LKepMLImGrjMaBnzYxRK7KA5j0Xk=; b=aR/7iMpMxZ4g5vs+DrnV6pTeJm/kUw9rjmspB3P9tQeaRWxnUKOp7DaBbuWJcTp5+q aFKGK7Q2/J/v8a7pK6z7gYH2V0uSBFhA/TB3jEHix5FM5EGrTGPTI370DekIGEqKEDTi gVbc7MW/r0vdQIkRgnWMyUCQHdn6uG8LLCT8uyafThUL5eG+wPoqplsLCq3AsHWHKrv2 1ix1h6hg19fo25wnJRokwQkarwa4WfwDh7JhOyG+Ncl4jrhWJi2KSZq2nE4RD3z8ShzF lD53o2vKVc41hlWqE8bIVUE8d0N6nIJ4qKIaSZWDmeDN4nQZ2qF2E56fA6eKUbq6PFKN 2w/w== X-Gm-Message-State: APjAAAVupkD3K0ZpYhZ4qHxq+5CakdwhzC9OXtWXCybXnnej1z7BQeT4 EQzemptaO3xvJNUUTwRBcqE= X-Google-Smtp-Source: APXvYqyLw49eump/ox38Z4zA11mDBtivQ61A7rJMxWU5H6pE4n+L8FeJt8/QHXENvF/U12TGXTn3sQ== X-Received: by 2002:a5d:44d2:: with SMTP id z18mr6605539wrr.122.1570551003336; Tue, 08 Oct 2019 09:10:03 -0700 (PDT) Received: from debian (207.148.159.143.dyn.plus.net. [143.159.148.207]) by smtp.gmail.com with ESMTPSA id f20sm3302107wmb.6.2019.10.08.09.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 09:10:02 -0700 (PDT) Date: Tue, 8 Oct 2019 17:10:01 +0100 From: Wei Liu To: Masahiro Yamada Cc: Wei Liu , Linux on Hyper-V List , Linux Kernel List , Linux Kconfig List , Wei Liu Subject: Re: [PATCH RFC] kconfig: add hvconfig for Linux on Hyper-V Message-ID: <20191008161001.lwiduq4mlyjumw5b@debian> References: <20191008131508.21189-1-liuw@liuw.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Oct 09, 2019 at 01:03:19AM +0900, Masahiro Yamada wrote: [...] > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > > index ef2f2336c469..2ee46301b22e 100644 > > --- a/scripts/kconfig/Makefile > > +++ b/scripts/kconfig/Makefile > > @@ -104,6 +104,10 @@ PHONY += xenconfig > > xenconfig: xen.config > > @: > > > > +PHONY += hvconfig > > +hvconfig: hv_guest.config > > + @: > > + > > > Does this need to be hooked up to kconfig Makefile? > It is not strictly necessary. Just thought it would be nice to follow existing examples. > In my understanding, this code provides > "make hvconfig" as a shorthand for "make hv_guest.config" > Yes that's correct. > Please do not do this. > > > See "xenconfig" as a bad example. > > "make xenconfig" is a shorthand of "make xen.config". > This exists to save just one character typing. > > > If I allow this, people would push more and more random pointless shorthands, > which are essentially unrelated to kconfig. > > > kvmconfig and xenconfig are just historical mistakes. > > > Please drop the changes to scripts/kconfig/Makefile. OK. > > Also, please do not use misleading "kconfig:" for the subject prefix. > You can use the subject prefix "hyper-v:" or something. > OK. Wei.