From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0431AECE58F for ; Wed, 16 Oct 2019 00:27:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC52620659 for ; Wed, 16 Oct 2019 00:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387890AbfJPA1D (ORCPT ); Tue, 15 Oct 2019 20:27:03 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728556AbfJPA1D (ORCPT ); Tue, 15 Oct 2019 20:27:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5E550120477A4; Tue, 15 Oct 2019 17:27:02 -0700 (PDT) Date: Tue, 15 Oct 2019 17:27:01 -0700 (PDT) Message-Id: <20191015.172701.464446938727284882.davem@davemloft.net> To: mikelley@microsoft.com Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, sashal@kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, himadrispandya@gmail.com Subject: Re: [PATCH net-next v2] hv_sock: use HV_HYP_PAGE_SIZE for Hyper-V communication From: David Miller In-Reply-To: <1570926595-8877-1-git-send-email-mikelley@microsoft.com> References: <1570926595-8877-1-git-send-email-mikelley@microsoft.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 15 Oct 2019 17:27:02 -0700 (PDT) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org From: Michael Kelley Date: Sun, 13 Oct 2019 00:30:21 +0000 > From: Himadri Pandya > > Current code assumes PAGE_SIZE (the guest page size) is equal > to the page size used to communicate with Hyper-V (which is > always 4K). While this assumption is true on x86, it may not > be true for Hyper-V on other architectures. For example, > Linux on ARM64 may have PAGE_SIZE of 16K or 64K. A new symbol, > HV_HYP_PAGE_SIZE, has been previously introduced to use when > the Hyper-V page size is intended instead of the guest page size. > > Make this code work on non-x86 architectures by using the new > HV_HYP_PAGE_SIZE symbol instead of PAGE_SIZE, where appropriate. > Also replace the now redundant PAGE_SIZE_4K with HV_HYP_PAGE_SIZE. > The change has no effect on x86, but lays the groundwork to run > on ARM64 and others. > > Signed-off-by: Himadri Pandya > Reviewed-by: Michael Kelley > --- > > Changes in v2: > * Revised commit message and subject [Jakub Kicinski] Applied, thank you.