Linux-HyperV List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: sashal@kernel.org, linux-hyperv@vger.kernel.org,
	netdev@vger.kernel.org, kys@microsoft.com,
	sthemmin@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix tx_table init in rndis_set_subchannel()
Date: Wed, 11 Dec 2019 14:22:11 -0800 (PST)	[thread overview]
Message-ID: <20191211.142211.1624810442420026092.davem@davemloft.net> (raw)
In-Reply-To: <1576101543-130334-1-git-send-email-haiyangz@microsoft.com>

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Wed, 11 Dec 2019 13:59:03 -0800

> Host can provide send indirection table messages anytime after RSS is
> enabled by calling rndis_filter_set_rss_param(). So the host provided
> table values may be overwritten by the initialization in
> rndis_set_subchannel().
> 
> To prevent this problem, move the tx_table initialization before calling
> rndis_filter_set_rss_param().
> 
> Fixes: a6fb6aa3cfa9 ("hv_netvsc: Set tx_table to equal weight after subchannels open")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Please format your subject lines properly.

	[PATCH $version $GIT_TREE] $subsystem_prefix: $description

Even the Fixes: tag had the proper subsystem prefix in it.

So your next posting must be of the form:

	[PATCH v2 net] hv_netvsc: Fix tx_table init in rndis_set_subchannel().

  reply	other threads:[~2019-12-11 22:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:59 [PATCH] Fix tx_table init in rndis_set_subchannel() Haiyang Zhang
2019-12-11 22:22 ` David Miller [this message]
2019-12-11 22:23   ` Haiyang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211.142211.1624810442420026092.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sashal@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox