From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F08C2D0C8 for ; Sun, 29 Dec 2019 00:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D6DE20838 for ; Sun, 29 Dec 2019 00:14:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="voTsJ8vp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfL2AN2 (ORCPT ); Sat, 28 Dec 2019 19:13:28 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42454 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfL2AN1 (ORCPT ); Sat, 28 Dec 2019 19:13:27 -0500 Received: by mail-pf1-f194.google.com with SMTP id 4so16569844pfz.9 for ; Sat, 28 Dec 2019 16:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X87rhBd+UktpzxH/iAqEZuIOWe5HFUhDknwlJQzhfXU=; b=voTsJ8vp2x4p14ymxvo5Co8MeX/z1qhzp6bl/TohpgNFc9WxmCWAQwghIETMHTZUv2 aBi+BnSePLkURSfUs0w3x8wB/1lGfEB85XpPg3VxQWxOiypONDGLPjgoRliHTozYJrjc yRoUyfLK9/nFxMJRoj16JyEdX717VnqfnWcLa4pdgO6s0z7uvQ34ZS6cJLF9nnZXTKL5 3WhHb4l4wcG4r4KUXGcEFfwuinsNVKSd2ArSNHdyMf5JtCzACGd7ANp6hhW5aPt6r2+c H82PthKARn9iHUG3OFb5whwJdGYtXcDx2FkeQ/hwhMbq2vKDV1jz1rES31/Wk8D8bmA4 pdfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X87rhBd+UktpzxH/iAqEZuIOWe5HFUhDknwlJQzhfXU=; b=HFof4eB9j0rGaIihxojD/9XKdisjjZDnpjoSQ/BOW3FgvT7pHqJKYRw1J96VGzFfnH dZ/XTgkLfjdg7feB4j/QZbQDU/u2n4GkyKsS/g9tIS6VAqXB2/CUdwVINLOT2CbPMHrW GLchriIwJmJ8CPw5ziLXsrCZLOZj3ggcDg+SrAMMg0yrkeIxFvh1BQ6/HfOu/Kt2JIQm ZL17puQY5dYSV1JKpU3kot0HWh42pxyjS9pqf9kmp+jIwsfUKqs16iNMArdBMv+lJEcm m/7GWRlWFWHqlyK8EfIDnRPkPsICpO5tWCxIj7fHgaPGp3A40ZYVpx+oxWt+J1Z/0CQT sDYQ== X-Gm-Message-State: APjAAAXjCr4IJBNLx/uWfs5TgZI4eg4ONkYfzbQzU62/YAHdGzdLAiuw 7bV+xCUSturnK/dunQ1xWXu3mw== X-Google-Smtp-Source: APXvYqxYpEanaEjAq3YfrtPVToWCHD2GjlB8uSTs6QmtEb5DIbUkXwnG3gWJgVXEwxnYGpMG3f/uJQ== X-Received: by 2002:a62:e511:: with SMTP id n17mr19323713pff.187.1577578407183; Sat, 28 Dec 2019 16:13:27 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f81sm46502970pfa.118.2019.12.28.16.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2019 16:13:26 -0800 (PST) Date: Sat, 28 Dec 2019 16:13:18 -0800 From: Stephen Hemminger To: Haiyang Zhang Cc: sashal@kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, kys@microsoft.com, sthemmin@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next, 3/3] hv_netvsc: Name NICs based on vmbus offer sequence and use async probe Message-ID: <20191228161318.4501bb79@hermes.lan> In-Reply-To: <1577576793-113222-4-git-send-email-haiyangz@microsoft.com> References: <1577576793-113222-1-git-send-email-haiyangz@microsoft.com> <1577576793-113222-4-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Sat, 28 Dec 2019 15:46:33 -0800 Haiyang Zhang wrote: > - net = alloc_etherdev_mq(sizeof(struct net_device_context), > - VRSS_CHANNEL_MAX); > + snprintf(name, IFNAMSIZ, "eth%d", dev->channel->dev_num); > + net = alloc_netdev_mqs(sizeof(struct net_device_context), name, > + NET_NAME_ENUM, ether_setup, > + VRSS_CHANNEL_MAX, VRSS_CHANNEL_MAX); > + Naming is a hard problem, and best left to userspace. By choosing ethN as a naming policy, you potentially run into naming conflicts with other non netvsc devices like those passed through or SR-IOV devices. Better to have udev use dev_num and use something like envN or something. Udev also handles SRIOV devices in later versions. Fighting against systemd, netplan, etc is not going to be make friends.