From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: sashal@kernel.org, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, kys@microsoft.com,
sthemmin@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH] hv_netvsc: Fix unwanted wakeup in netvsc_attach()
Date: Sun, 23 Feb 2020 16:33:02 -0800 (PST) [thread overview]
Message-ID: <20200223.163302.12435682075168491.davem@davemloft.net> (raw)
In-Reply-To: <1582302738-24352-1-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 21 Feb 2020 08:32:18 -0800
> When netvsc_attach() is called by operations like changing MTU, etc.,
> an extra wakeup may happen while netvsc_attach() calling
> rndis_filter_device_add() which sends rndis messages when queue is
> stopped in netvsc_detach(). The completion message will wake up queue 0.
>
> We can reproduce the issue by changing MTU etc., then the wake_queue
> counter from "ethtool -S" will increase beyond stop_queue counter:
> stop_queue: 0
> wake_queue: 1
> The issue causes queue wake up, and counter increment, no other ill
> effects in current code. So we didn't see any network problem for now.
>
> To fix this, initialize tx_disable to true, and set it to false when
> the NIC is ready to be attached or registered.
>
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied, thank you.
prev parent reply other threads:[~2020-02-24 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:32 [net PATCH] hv_netvsc: Fix unwanted wakeup in netvsc_attach() Haiyang Zhang
2020-02-24 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200223.163302.12435682075168491.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox