From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: "ltykernel@gmail.com" <ltykernel@gmail.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <liuwe@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
vkuznets <vkuznets@redhat.com>, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH V4 6/6] x86/Hyper-V: Report crash data in die() when panic_on_oops is set
Date: Thu, 9 Apr 2020 17:40:54 +0100 [thread overview]
Message-ID: <20200409164054.72es2ykmbef3jbui@debian> (raw)
In-Reply-To: <MW2PR2101MB10524CB8CBF3FE49C2EDAA8DD7C00@MW2PR2101MB1052.namprd21.prod.outlook.com>
On Wed, Apr 08, 2020 at 08:19:47PM +0000, Michael Kelley wrote:
> From: Tianyu Lan <Tianyu.Lan@microsoft.com> Sent: Monday, April 6, 2020 8:54 AM
> >
> > When oops happens with panic_on_oops unset, the oops
> > thread is killed by die() and system continues to run.
> > In such case, guest should not report crash register
> > data to host since system still runs. Check panic_on_oops
> > and return directly in hyperv_report_panic() when the function
> > is called in the die() and panic_on_oops is unset. Fix it.
> >
> > Fixes: 7ed4325a44ea ("Drivers: hv: vmbus: Make panic reporting to be more useful")
> > Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
> > ---
> > Change since v3:
> > - Fix compile error.
> > - Add fix commit in the change log
> > ---
> > arch/x86/hyperv/hv_init.c | 6 +++++-
> > drivers/hv/vmbus_drv.c | 5 +++--
> > include/asm-generic/mshyperv.h | 2 +-
> > 3 files changed, 9 insertions(+), 4 deletions(-)
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
It seems to me only the last patch is new, others are already in my
tree, so I only apply the last one.
Let me know if my understanding is wrong.
Wei.
next prev parent reply other threads:[~2020-04-09 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 15:53 [PATCH V4 0/6] x86/Hyper-V: Panic code path fixes ltykernel
2020-04-06 15:53 ` [PATCH V4 1/6] x86/Hyper-V: Unload vmbus channel in hv panic callback ltykernel
2020-04-06 15:53 ` [PATCH V4 2/6] x86/Hyper-V: Free hv_panic_page when fail to register kmsg dump ltykernel
2020-04-06 15:53 ` [PATCH V4 3/6] x86/Hyper-V: Trigger crash enlightenment only once during 0;136;0c0;136;0c system crash ltykernel
2020-04-06 15:53 ` [PATCH V4 4/6] x86/Hyper-V: Report crash register data or kmsg before running crash kernel ltykernel
2020-04-06 15:53 ` [PATCH V4 5/6] x86/Hyper-V: Report crash register data when sysctl_record_panic_msg is not set ltykernel
2020-04-06 15:53 ` [PATCH V4 6/6] x86/Hyper-V: Report crash data in die() when panic_on_oops is set ltykernel
2020-04-08 20:19 ` Michael Kelley
2020-04-09 16:40 ` Wei Liu [this message]
2020-04-09 23:06 ` Michael Kelley
2020-04-10 14:27 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2020-03-24 7:57 [PATCH V3 " ltykernel
2020-03-31 7:38 ` [PATCH V4 " ltykernel
2020-03-31 13:51 ` Michael Kelley
2020-03-31 14:26 ` Tianyu Lan
2020-04-01 18:53 ` Wei Liu
2020-04-02 12:51 ` Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409164054.72es2ykmbef3jbui@debian \
--to=wei.liu@kernel.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=ltykernel@gmail.com \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).