From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A5FC4742C for ; Fri, 13 Nov 2020 12:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 289B022250 for ; Fri, 13 Nov 2020 12:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbgKMMEm (ORCPT ); Fri, 13 Nov 2020 07:04:42 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51881 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726769AbgKMLf5 (ORCPT ); Fri, 13 Nov 2020 06:35:57 -0500 Received: by mail-wm1-f66.google.com with SMTP id 19so7804298wmf.1; Fri, 13 Nov 2020 03:33:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d1KWoyCxIzbC720+xBKrOQK15eEM1twXcAUiyfQaowY=; b=JIqVVi9c9kNdRyw5tkLqltHLN5/nzUR+ySI4XdSnbhE26Il1j3e+FfAlgg+7a/2MQu co1ICWyxuikOfTnCLyQZ62QnJqKOUjKG2Lzo7qTkDyCQOtwZQYWgt7pjpVQEMeUywvWS aQB25urWOe0gi2h8AurBqGmQmqKOEMi0G4ye6HRUF46LUk7Go6zMuyfs0ckbIvyu5scb Jzy+xBsYQMnURpMM3MlxoM5aH6F79OllRYo8BWD6Jb7Cu+36s09RwSTLoEA7Qu0QAExM JBMzOBF/ng2Tw5fwy4yr1m7iTvPpGR7lDd/ZlkYbv+3JJmfizfjquojqOHwEE9ctvxH/ R7UA== X-Gm-Message-State: AOAM532/Si8K+4HsuS6yfuX8aDne+tqiMuGAaIDaeEIPPZYNwUVykte5 fEf6lQ0F9lckXp1K2oLzA7g= X-Google-Smtp-Source: ABdhPJxZQBzcTMRf76DZPR7PoAp2gCxSuinKtUAttdgGTrLJLVoAxY9BA2m1AN6Pt/+0k8Cse7RRcg== X-Received: by 2002:a1c:398a:: with SMTP id g132mr2151643wma.51.1605267223132; Fri, 13 Nov 2020 03:33:43 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id z189sm5194304wme.23.2020.11.13.03.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 03:33:42 -0800 (PST) Date: Fri, 13 Nov 2020 11:33:41 +0000 From: Wei Liu To: "Andrea Parri (Microsoft)" Cc: linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org, Andres Beltran , Michael Kelley , Saruhan Karademir , Juan Vazquez , Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v9 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20201113113341.kwc2fwpqzhqztgms@liuwe-devbox-debian-v2> References: <20201109100402.8946-1-parri.andrea@gmail.com> <20201109100402.8946-4-parri.andrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109100402.8946-4-parri.andrea@gmail.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, Nov 09, 2020 at 11:04:02AM +0100, Andrea Parri (Microsoft) wrote: > From: Andres Beltran > > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in netvsc. In the face of errors or malicious > behavior in Hyper-V, netvsc should not expose or trust the transaction > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > use small integers generated by vmbus_requestor as requests > (transaction) IDs. > > Signed-off-by: Andres Beltran > Co-developed-by: Andrea Parri (Microsoft) > Signed-off-by: Andrea Parri (Microsoft) > Reviewed-by: Michael Kelley > Acked-by: Jakub Kicinski > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org Reviewed-by: Wei Liu