From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BF5C64E7B for ; Wed, 2 Dec 2020 14:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA0E221EB for ; Wed, 2 Dec 2020 14:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728549AbgLBOLw (ORCPT ); Wed, 2 Dec 2020 09:11:52 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34811 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728194AbgLBOLv (ORCPT ); Wed, 2 Dec 2020 09:11:51 -0500 Received: by mail-wr1-f68.google.com with SMTP id k14so4142842wrn.1; Wed, 02 Dec 2020 06:11:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VFmvo9qAPDBPuqmhfbmjzQYI5Z9eFTcq3dsoBi3Wl9w=; b=QCOmxSWOTiFtxi3oURXsJazbEgKZ6uL+LCQOY3XTsCmJOONtUSVxa39+uWo5Oi82pz ZhfdNl3+XubxZGAXnzkmUkng34O1O3KkLOybvxr/BQo/5TcqlpWO59I2FI82RqveNoDZ geNUDn0tn5S2VrYqYGMrvc7qgtcbVHMzzHEO/mjkh06AHfgEEFu8RHV2pDtgDZRItqkG 276qT5BmxhrrpmJ/H0XibbPWcZALV0WpUqLIxRD4tV6ei8bsRWy6ihWuLZ8sHwSgDHsJ hfDylvt1yesGJ5uGT53RE3rM2XUz9SQfLNg8liLdxvBaq9fhuphXYtbUws4V+pG7tpyB Re+Q== X-Gm-Message-State: AOAM531Chkm/PyeXT9QMR9WgS0Bsl3W15EKJuuGk87GAkG7Q+Kr6ehBF fnCQiMKYk+LR4cQKcvCRWOU= X-Google-Smtp-Source: ABdhPJyjPIEmj2CHj7Ial9lkzZOaHh/npZJoOOgmYWKnG5gPqCZZMyjNJ/pf2mX44pIPPdRc5CbI6Q== X-Received: by 2002:a5d:6783:: with SMTP id v3mr3689699wru.45.1606918269807; Wed, 02 Dec 2020 06:11:09 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id q17sm2565999wro.36.2020.12.02.06.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 06:11:09 -0800 (PST) Date: Wed, 2 Dec 2020 14:11:07 +0000 From: Wei Liu To: Andy Shevchenko Cc: Wei Liu , Linux on Hyper-V List , virtualization@lists.linux-foundation.org, Linux Kernel List , Michael Kelley , Vineeth Pillai , Sunil Muthuswamy , Nuno Das Neves , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Joerg Roedel , Bjorn Helgaas , Andy Shevchenko , Jon Derrick , YueHaibing , "Gustavo A. R. Silva" Subject: Re: [PATCH v3 16/17] x86/ioapic: export a few functions and data structures via io_apic.h Message-ID: <20201202141107.covsx4ugipuyl6he@liuwe-devbox-debian-v2> References: <20201124170744.112180-1-wei.liu@kernel.org> <20201124170744.112180-17-wei.liu@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Nov 25, 2020 at 12:26:12PM +0200, Andy Shevchenko wrote: > On Wed, Nov 25, 2020 at 1:46 AM Wei Liu wrote: > > > > We are about to implement an irqchip for IO-APIC when Linux runs as root > > on Microsoft Hypervisor. At the same time we would like to reuse > > existing code as much as possible. > > > > Move mp_chip_data to io_apic.h and make a few helper functions > > non-static. > > > +struct mp_chip_data { > > + struct list_head irq_2_pin; > > + struct IO_APIC_route_entry entry; > > + int trigger; > > + int polarity; > > + u32 count; > > + bool isa_irq; > > +}; > > Since I see only this patch I am puzzled why you need to have this in > the header? > Maybe a couple of words in the commit message to elaborate? Andy, does the following answer your question? "The chip_data stashed in IO-APIC's irq chip is mp_chip_data. The implementation of Microsoft Hypevisor's IO-APIC irqdomain would like to manipulate that data structure, so move it to io_apic.h as well." If that's good enough, I can add it to the commit message. Wei.