From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3D4C433DB for ; Wed, 23 Dec 2020 09:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3ADD22475 for ; Wed, 23 Dec 2020 09:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728089AbgLWJAW (ORCPT ); Wed, 23 Dec 2020 04:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727050AbgLWJAV (ORCPT ); Wed, 23 Dec 2020 04:00:21 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CDA3C0613D3; Wed, 23 Dec 2020 00:59:41 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id b9so21900399ejy.0; Wed, 23 Dec 2020 00:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ES/8ieI8Kxtel9JlAtC3s+3/PUrp/OzcZLFZoDxjKqA=; b=UEgPNhyUF5K0K5Vluw21w7F/F+PiR6V0PvyX0LR/kqwJFtEZ07Np/8GaGkf6SGP69p WQXYZ/f/6aWTTl8X3Cc3cf9FF3sAGnp9OzwnFWH/GpQm2fBmAxPvjZbazvjxFCcOr8PP ENqF5X7spWt4IKytN8sv4cXmTNazBVox1hQa/nZokeByRAi+RvwND43NMyD+NvXOiDYc ikYwybT2Wsr7aEzO/qBGt+2ivuPab/Et9sHbYC4P6sMD3ijFyWNNKwUbTv/zfvSA/GID V/hM1EWoh1hX0iztJ0kz5X1BdaD4EEnBg+2kMIAoimucpKP+fja//SMUNtbsLakkEXvD gsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ES/8ieI8Kxtel9JlAtC3s+3/PUrp/OzcZLFZoDxjKqA=; b=VAHgWKgvRoXOQE47++aGLmzrEuMT5SoNpJjfW/ltjR1rDe4hec0t0KJRU0p6QbUV6x +YJWhJh3x6xvWvvoV/MnUZ1H++6AIMsW+g+vvBHRYdytJnPH9reVwv+MSBft9sZsSWWq E+ScKTok7kGqcT/07pMLI0Put3nIzJypZ/wsz8cKhcxipQUIHKbarHOijWbzFh9Gamgu HwR8Yuec5MWsjXWeQU5N6AbcgG+k08HejDTv6HsB3i0TNOQqS2ft1Sb5om3oMab+RNWC c8+zWjfaNEuhtwWw2qOhgJ4iiHCEDBl1ALHINfHZ9jGzX5caNpRDX4yJcQ1cIc1TgY16 6U1A== X-Gm-Message-State: AOAM531ymATFTF+xm69xQMsHxT0mGo0mknPBI2oURJXEA3AyO5o+V2hv rhhsdBtjc62aSab/53icK2Q= X-Google-Smtp-Source: ABdhPJxJa7VIjYxxaH3afq1nZmDskCd4o4RjZYDvXMckqFCAULCCx1rexAClald7Csj5LrMJ3Bdhtw== X-Received: by 2002:a17:906:cb86:: with SMTP id mf6mr22786625ejb.57.1608713979695; Wed, 23 Dec 2020 00:59:39 -0800 (PST) Received: from andrea (host-95-239-64-30.retail.telecomitalia.it. [95.239.64.30]) by smtp.gmail.com with ESMTPSA id n2sm11289270ejj.24.2020.12.23.00.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Dec 2020 00:59:39 -0800 (PST) Date: Wed, 23 Dec 2020 09:59:31 +0100 From: Andrea Parri To: Michael Kelley Cc: Sasha Levin , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Saruhan Karademir , Haiyang Zhang , Jakub Kicinski , "David S. Miller" , "netdev@vger.kernel.org" , Wei Liu , "linux-hyperv@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels Message-ID: <20201223085931.GA2683@andrea> References: <20201223022253.2793452-1-sashal@kernel.org> <20201223022253.2793452-40-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Dec 23, 2020 at 02:47:56AM +0000, Michael Kelley wrote: > From: Sasha Levin Sent: Tuesday, December 22, 2020 6:22 PM > > > > From: "Andrea Parri (Microsoft)" > > > > [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] > > > > Lack of validation could lead to out-of-bound reads and information > > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > > allocated sub-channels fits into the expected range. > > > > Suggested-by: Saruhan Karademir > > Signed-off-by: Andrea Parri (Microsoft) > > Reviewed-by: Haiyang Zhang > > Acked-by: Jakub Kicinski > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: netdev@vger.kernel.org > > Link: > > https://lore.kernel.org/linux-hyperv/20201118153310.112404-1-parri.andrea@gmail.com/ > > Signed-off-by: Wei Liu > > Signed-off-by: Sasha Levin > > --- > > drivers/net/hyperv/rndis_filter.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > Sasha -- This patch is one of an ongoing group of patches where a Linux > guest running on Hyper-V will start assuming that hypervisor behavior might > be malicious, and guards against such behavior. Because this is a new > assumption, these patches are more properly treated as new functionality > rather than as bug fixes. So I would propose that we *not* bring such patches > back to stable branches. Thank you, Michael. Just to confirm, I agree with Michael's assessment above and I join his proposal to *not* backport such patches to stable. Thanks, Andrea