From: Sasha Levin <sashal@kernel.org>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Juan Vazquez <juvazq@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host
Date: Fri, 26 Feb 2021 12:05:53 -0500 [thread overview]
Message-ID: <20210226170553.GB473487@sasha-vm> (raw)
In-Reply-To: <20210224133052.GA2058@anparri>
On Wed, Feb 24, 2021 at 02:30:52PM +0100, Andrea Parri wrote:
>On Wed, Feb 24, 2021 at 02:16:00PM +0100, Andrea Parri wrote:
>> On Wed, Feb 24, 2021 at 07:50:08AM -0500, Sasha Levin wrote:
>> > From: "Andrea Parri (Microsoft)" <parri.andrea@gmail.com>
>> >
>> > [ Upstream commit e99c4afbee07e9323e9191a20b24d74dbf815bdf ]
>> >
>> > __vmbus_open() and vmbus_teardown_gpadl() do not inizialite the memory
>> > for the vmbus_channel_open_channel and the vmbus_channel_gpadl_teardown
>> > objects they allocate respectively. These objects contain padding bytes
>> > and fields that are left uninitialized and that are later sent to the
>> > host, potentially leaking guest data. Zero initialize such fields to
>> > avoid leaking sensitive information to the host.
>> >
>> > Reported-by: Juan Vazquez <juvazq@microsoft.com>
>> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
>> > Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>> > Link: https://lore.kernel.org/r/20201209070827.29335-2-parri.andrea@gmail.com
>> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
>> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>>
>> Sasha - This patch is one of a group of patches where a Linux guest running on
>> Hyper-V will start assuming that hypervisor behavior might be malicious, and
>> guards against such behavior. Because this is a new assumption, these patches
>> are more properly treated as new functionality rather than as bug fixes. So I
>> would propose that we *not* bring such patches back to stable branches.
>
>For future/similar cases: I'm wondering, is there some way to annotate a patch
>with "please do not bring it back"?
There's nothing explicit for the AUTOSEL stuff. A note in the changelog
could work.
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-02-26 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210224125026.481804-1-sashal@kernel.org>
2021-02-24 12:50 ` [PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host Sasha Levin
2021-02-24 13:16 ` Andrea Parri
2021-02-24 13:30 ` Andrea Parri
2021-02-26 17:05 ` Sasha Levin [this message]
2021-02-24 12:50 ` [PATCH AUTOSEL 5.11 51/67] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind() Sasha Levin
2021-02-24 13:17 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226170553.GB473487@sasha-vm \
--to=sashal@kernel.org \
--cc=juvazq@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=parri.andrea@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).