* [PATCH -next] x86: Fix unused variable 'hi'
@ 2021-03-18 7:46 Xu Yihang
2021-03-18 11:24 ` Ingo Molnar
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Xu Yihang @ 2021-03-18 7:46 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa
Cc: linux-hyperv, linux-kernel, xuyihang
Fixes the following W=1 kernel build warning(s):
arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xu Yihang <xuyihang@huawei.com>
---
arch/x86/hyperv/hv_apic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
index 284e73661a18..c0b0a5774f31 100644
--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
@@ -55,7 +55,8 @@ static void hv_apic_icr_write(u32 low, u32 id)
static u32 hv_apic_read(u32 reg)
{
- u32 reg_val, hi;
+ u32 hi __maybe_unused;
+ u32 reg_val;
switch (reg) {
case APIC_EOI:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH -next] x86: Fix unused variable 'hi'
2021-03-18 7:46 [PATCH -next] x86: Fix unused variable 'hi' Xu Yihang
@ 2021-03-18 11:24 ` Ingo Molnar
2021-03-19 18:58 ` Michael Kelley
[not found] ` <20210322035426.71169-1-xuyihang@huawei.com>
2021-03-23 2:50 ` Xu Yihang
2 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2021-03-18 11:24 UTC (permalink / raw)
To: Xu Yihang
Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa,
linux-hyperv, linux-kernel
* Xu Yihang <xuyihang@huawei.com> wrote:
> Fixes the following W=1 kernel build warning(s):
> arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Yihang <xuyihang@huawei.com>
> ---
> arch/x86/hyperv/hv_apic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> index 284e73661a18..c0b0a5774f31 100644
> --- a/arch/x86/hyperv/hv_apic.c
> +++ b/arch/x86/hyperv/hv_apic.c
> @@ -55,7 +55,8 @@ static void hv_apic_icr_write(u32 low, u32 id)
>
> static u32 hv_apic_read(u32 reg)
> {
> - u32 reg_val, hi;
> + u32 hi __maybe_unused;
> + u32 reg_val;
>
> switch (reg) {
> case APIC_EOI:
Why and under what config does this function trigger the warning?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH -next] x86: Fix unused variable 'hi'
2021-03-18 11:24 ` Ingo Molnar
@ 2021-03-19 18:58 ` Michael Kelley
0 siblings, 0 replies; 8+ messages in thread
From: Michael Kelley @ 2021-03-19 18:58 UTC (permalink / raw)
To: Ingo Molnar, Xu Yihang
Cc: KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
wei.liu@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
From: Ingo Molnar <mingo.kernel.org@gmail.com> Sent: Thursday, March 18, 2021 4:24 AM
>
> * Xu Yihang <xuyihang@huawei.com> wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> > arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-
> set-variable]
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Xu Yihang <xuyihang@huawei.com>
> > ---
> > arch/x86/hyperv/hv_apic.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> > index 284e73661a18..c0b0a5774f31 100644
> > --- a/arch/x86/hyperv/hv_apic.c
> > +++ b/arch/x86/hyperv/hv_apic.c
> > @@ -55,7 +55,8 @@ static void hv_apic_icr_write(u32 low, u32 id)
> >
> > static u32 hv_apic_read(u32 reg)
> > {
> > - u32 reg_val, hi;
> > + u32 hi __maybe_unused;
> > + u32 reg_val;
> >
> > switch (reg) {
> > case APIC_EOI:
>
> Why and under what config does this function trigger the warning?
>
> Thanks,
>
> Ingo
The warning should trigger if CONFIG_HYPERV is "m" or "y", and W=1
is selected. The variable is indeed set but not used because only the
low order 32 bits of the synthetic MSR are relevant, but rdmsr() returns
both the low 32 and the high 32 bits.
Michael
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20210322035426.71169-1-xuyihang@huawei.com>]
* [PATCH -next] x86: Fix unused variable 'hi'
[not found] ` <20210322035426.71169-1-xuyihang@huawei.com>
@ 2021-03-22 3:54 ` Xu Yihang
2021-03-22 11:02 ` Wei Liu
0 siblings, 1 reply; 8+ messages in thread
From: Xu Yihang @ 2021-03-22 3:54 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa
Cc: linux-hyperv, linux-kernel, xuyihang, johnny.chenyi
Fixes the following W=1 kernel build warning(s):
arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
Compiled with CONFIG_HYPERV enabled:
make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
make W=1 arch/x86/hyperv/hv_apic.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
HV_X64_MSR_EOI stores on bit 31:0 and HV_X64_MSR_TPR stores in bit 7:0, which means higher 32 bits are not really used, therefore __maybe_unused added.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xu Yihang <xuyihang@huawei.com>
---
arch/x86/hyperv/hv_apic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
index 284e73661a18..c0b0a5774f31 100644
--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
@@ -55,7 +55,8 @@ static void hv_apic_icr_write(u32 low, u32 id)
static u32 hv_apic_read(u32 reg)
{
- u32 reg_val, hi;
+ u32 hi __maybe_unused;
+ u32 reg_val;
switch (reg) {
case APIC_EOI:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH -next] x86: Fix unused variable 'hi'
2021-03-22 3:54 ` Xu Yihang
@ 2021-03-22 11:02 ` Wei Liu
0 siblings, 0 replies; 8+ messages in thread
From: Wei Liu @ 2021-03-22 11:02 UTC (permalink / raw)
To: Xu Yihang
Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa,
linux-hyperv, linux-kernel, johnny.chenyi
On Mon, Mar 22, 2021 at 11:54:26AM +0800, Xu Yihang wrote:
> Fixes the following W=1 kernel build warning(s):
> arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
>
> Compiled with CONFIG_HYPERV enabled:
> make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
> make W=1 arch/x86/hyperv/hv_apic.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
>
> HV_X64_MSR_EOI stores on bit 31:0 and HV_X64_MSR_TPR stores in bit 7:0, which means higher 32 bits are not really used, therefore __maybe_unused added.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Yihang <xuyihang@huawei.com>
I slightly modified the commit message and queued it up for hyperv-next.
Thanks.
Wei.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -next] x86: Fix unused variable 'hi'
2021-03-18 7:46 [PATCH -next] x86: Fix unused variable 'hi' Xu Yihang
2021-03-18 11:24 ` Ingo Molnar
[not found] ` <20210322035426.71169-1-xuyihang@huawei.com>
@ 2021-03-23 2:50 ` Xu Yihang
2021-03-23 11:32 ` Wei Liu
2 siblings, 1 reply; 8+ messages in thread
From: Xu Yihang @ 2021-03-23 2:50 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa
Cc: linux-hyperv, linux-kernel, xuyihang, johnny.chenyi
Fixes the following W=1 kernel build warning(s):
arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
Compiled with CONFIG_HYPERV enabled:
make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
make W=1 arch/x86/hyperv/hv_apic.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
HV_X64_MSR_EOI stores on bit 31:0 and HV_X64_MSR_TPR stores in bit 7:0, which means higher
32 bits are not really used, therefore potentially cast to void in order to silent this warning.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xu Yihang <xuyihang@huawei.com>
---
arch/x86/hyperv/hv_apic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
index 284e73661a18..a8b639498033 100644
--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
@@ -60,9 +60,11 @@ static u32 hv_apic_read(u32 reg)
switch (reg) {
case APIC_EOI:
rdmsr(HV_X64_MSR_EOI, reg_val, hi);
+ (void) hi;
return reg_val;
case APIC_TASKPRI:
rdmsr(HV_X64_MSR_TPR, reg_val, hi);
+ (void) hi;
return reg_val;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH -next] x86: Fix unused variable 'hi'
2021-03-23 2:50 ` Xu Yihang
@ 2021-03-23 11:32 ` Wei Liu
2021-03-24 11:34 ` Wei Liu
0 siblings, 1 reply; 8+ messages in thread
From: Wei Liu @ 2021-03-23 11:32 UTC (permalink / raw)
To: Xu Yihang
Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa,
linux-hyperv, linux-kernel, johnny.chenyi
On Tue, Mar 23, 2021 at 10:50:13AM +0800, Xu Yihang wrote:
> Fixes the following W=1 kernel build warning(s):
> arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
>
> Compiled with CONFIG_HYPERV enabled:
> make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
> make W=1 arch/x86/hyperv/hv_apic.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
>
> HV_X64_MSR_EOI stores on bit 31:0 and HV_X64_MSR_TPR stores in bit 7:0, which means higher
> 32 bits are not really used, therefore potentially cast to void in order to silent this warning.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Yihang <xuyihang@huawei.com>
> ---
> arch/x86/hyperv/hv_apic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> index 284e73661a18..a8b639498033 100644
> --- a/arch/x86/hyperv/hv_apic.c
> +++ b/arch/x86/hyperv/hv_apic.c
> @@ -60,9 +60,11 @@ static u32 hv_apic_read(u32 reg)
> switch (reg) {
> case APIC_EOI:
> rdmsr(HV_X64_MSR_EOI, reg_val, hi);
> + (void) hi;
> return reg_val;
> case APIC_TASKPRI:
> rdmsr(HV_X64_MSR_TPR, reg_val, hi);
> + (void) hi;
I would like to remove the space while committing this patch. There is
no need for you to do anything.
Wei.
> return reg_val;
>
> default:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH -next] x86: Fix unused variable 'hi'
2021-03-23 11:32 ` Wei Liu
@ 2021-03-24 11:34 ` Wei Liu
0 siblings, 0 replies; 8+ messages in thread
From: Wei Liu @ 2021-03-24 11:34 UTC (permalink / raw)
To: Xu Yihang
Cc: kys, haiyangz, sthemmin, wei.liu, tglx, mingo, bp, x86, hpa,
linux-hyperv, linux-kernel, johnny.chenyi
On Tue, Mar 23, 2021 at 11:32:50AM +0000, Wei Liu wrote:
> On Tue, Mar 23, 2021 at 10:50:13AM +0800, Xu Yihang wrote:
> > Fixes the following W=1 kernel build warning(s):
> > arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
> >
> > Compiled with CONFIG_HYPERV enabled:
> > make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
> > make W=1 arch/x86/hyperv/hv_apic.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-
> >
> > HV_X64_MSR_EOI stores on bit 31:0 and HV_X64_MSR_TPR stores in bit 7:0, which means higher
> > 32 bits are not really used, therefore potentially cast to void in order to silent this warning.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Xu Yihang <xuyihang@huawei.com>
> > ---
> > arch/x86/hyperv/hv_apic.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> > index 284e73661a18..a8b639498033 100644
> > --- a/arch/x86/hyperv/hv_apic.c
> > +++ b/arch/x86/hyperv/hv_apic.c
> > @@ -60,9 +60,11 @@ static u32 hv_apic_read(u32 reg)
> > switch (reg) {
> > case APIC_EOI:
> > rdmsr(HV_X64_MSR_EOI, reg_val, hi);
> > + (void) hi;
> > return reg_val;
> > case APIC_TASKPRI:
> > rdmsr(HV_X64_MSR_TPR, reg_val, hi);
> > + (void) hi;
>
> I would like to remove the space while committing this patch. There is
> no need for you to do anything.
Applied to hyperv-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-24 11:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-18 7:46 [PATCH -next] x86: Fix unused variable 'hi' Xu Yihang
2021-03-18 11:24 ` Ingo Molnar
2021-03-19 18:58 ` Michael Kelley
[not found] ` <20210322035426.71169-1-xuyihang@huawei.com>
2021-03-22 3:54 ` Xu Yihang
2021-03-22 11:02 ` Wei Liu
2021-03-23 2:50 ` Xu Yihang
2021-03-23 11:32 ` Wei Liu
2021-03-24 11:34 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).