From: Wei Liu <wei.liu@kernel.org>
To: Praveen Kumar <kumarpraveen@linux.microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, decui@microsoft.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, nunodasneves@linux.microsoft.com,
viremana@linux.microsoft.com, sunilmut@microsoft.com,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH] x86/hyperv: LP creation with lp_index on same CPU-id
Date: Wed, 2 Jun 2021 15:16:12 +0000 [thread overview]
Message-ID: <20210602151612.7wz2ni4iyw7uzufm@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <572da60e-714f-b207-a89e-6dc40209e2da@linux.microsoft.com>
On Mon, May 31, 2021 at 04:31:04PM +0530, Praveen Kumar wrote:
>
>
> On 5/31/2021 4:27 PM, Wei Liu wrote:
> > On Mon, May 31, 2021 at 01:10:46PM +0530, Praveen Kumar wrote:
> >> The hypervisor expects the lp_index to be same as cpu-id during LP creation
> >> This fix correct the same, as cpu_physical_id can give different cpu-id.
> >
> > Code looks fine to me, but the commit message can be made clearer.
> >
> > """
> > The hypervisor expects the logical processor index to be the same as
> > CPU's id during logical processor creation. Using cpu_physical_id
> > confuses Microsoft Hypervisor's scheduler. That causes the root
> > partition not boot when core scheduler is used.
> >
> > This patch removes the call to cpu_physical_id and uses the CPU index
> > directly for bringing up logical processor. This scheme works for both
> > classic scheduler and core scheduler.
> >
> > Fixes: 333abaf5abb3 (x86/hyperv: implement and use hv_smp_prepare_cpus)
> > """
> >
> > No action is required from you. If you are fine with this commit message
> > I can incorporate it and update the subject line when committing this
> > patch.
> >
>
> Thanks Wei for your comments. I'm fine with your inputs. Please go ahead. Thanks.
Pushed to hyperv-next. Thanks.
prev parent reply other threads:[~2021-06-02 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:40 [PATCH] x86/hyperv: LP creation with lp_index on same CPU-id Praveen Kumar
2021-05-31 10:57 ` Wei Liu
2021-05-31 11:01 ` Praveen Kumar
2021-06-02 15:16 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602151612.7wz2ni4iyw7uzufm@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=bp@alien8.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=viremana@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).