* [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build [not found] <20211220143023.451982183@linuxfoundation.org> @ 2021-12-20 14:34 ` Greg Kroah-Hartman 2021-12-20 20:31 ` Pavel Machek 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2021-12-20 14:34 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, stable, Randy Dunlap, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Sasha Levin From: Randy Dunlap <rdunlap@infradead.org> [ Upstream commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 ] The hyperv utilities use PTP clock interfaces and should depend a a kconfig symbol such that they will be built as a loadable module or builtin so that linker errors do not happen. Prevents these build errors: ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' ld: drivers/hv/hv_util.o: in function `hv_timesync_init': hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Cc: Wei Liu <wei.liu@kernel.org> Cc: Dexuan Cui <decui@microsoft.com> Cc: linux-hyperv@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Michael Kelley <mikelley@microsoft.com> Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org Signed-off-by: Wei Liu <wei.liu@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/hv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 1c1a2514d6f31..b1c93441900ad 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -16,6 +16,7 @@ config HYPERV_TSCPAGE config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" depends on HYPERV && CONNECTOR && NLS + depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities. -- 2.33.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build 2021-12-20 14:34 ` [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Greg Kroah-Hartman @ 2021-12-20 20:31 ` Pavel Machek 2021-12-20 20:49 ` Arnd Bergmann 2021-12-22 7:54 ` Greg Kroah-Hartman 0 siblings, 2 replies; 4+ messages in thread From: Pavel Machek @ 2021-12-20 20:31 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-kernel, stable, Randy Dunlap, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Sasha Levin [-- Attachment #1: Type: text/plain, Size: 1175 bytes --] Hi! > From: Randy Dunlap <rdunlap@infradead.org> > > [ Upstream commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 ] > > The hyperv utilities use PTP clock interfaces and should depend a > a kconfig symbol such that they will be built as a loadable module or > builtin so that linker errors do not happen. > > Prevents these build errors: > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' This is bad idea for 4.19: > +++ b/drivers/hv/Kconfig > @@ -16,6 +16,7 @@ config HYPERV_TSCPAGE > config HYPERV_UTILS > tristate "Microsoft Hyper-V Utilities driver" > depends on HYPERV && CONNECTOR && NLS > + depends on PTP_1588_CLOCK_OPTIONAL > help > Select this option to enable the Hyper-V Utilities. grep -ri PTP_1588_CLOCK_OPTIONAL . Results in no result in 4.19. So this will break hyperv. No results in 5.10, either, so it is bad idea there, too. Pavel -- http://www.livejournal.com/~pavelmachek [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build 2021-12-20 20:31 ` Pavel Machek @ 2021-12-20 20:49 ` Arnd Bergmann 2021-12-22 7:54 ` Greg Kroah-Hartman 1 sibling, 0 replies; 4+ messages in thread From: Arnd Bergmann @ 2021-12-20 20:49 UTC (permalink / raw) To: Pavel Machek Cc: Greg Kroah-Hartman, Linux Kernel Mailing List, # 3.4.x, Randy Dunlap, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, Linux on Hyper-V List, Michael Kelley, Sasha Levin On Mon, Dec 20, 2021 at 9:31 PM Pavel Machek <pavel@ucw.cz> wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > [ Upstream commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 ] > > > > The hyperv utilities use PTP clock interfaces and should depend a > > a kconfig symbol such that they will be built as a loadable module or > > builtin so that linker errors do not happen. > > > > Prevents these build errors: > > > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > This is bad idea for 4.19: > > > +++ b/drivers/hv/Kconfig > > @@ -16,6 +16,7 @@ config HYPERV_TSCPAGE > > config HYPERV_UTILS > > tristate "Microsoft Hyper-V Utilities driver" > > depends on HYPERV && CONNECTOR && NLS > > + depends on PTP_1588_CLOCK_OPTIONAL > > help > > Select this option to enable the Hyper-V Utilities. > > grep -ri PTP_1588_CLOCK_OPTIONAL . > > Results in no result in 4.19. So this will break hyperv. No results in > 5.10, either, so it is bad idea there, too. Right, this doesn't work, but the bug does exist anyway, and could be fixed by listing the dependency explicitly as depends on PTP_1588_CLOCK || PTP_1588_CLOCK=n The PTP_1588_CLOCK_OPTIONAL was added as a shortcut to avoid the odd Kconfig syntax that most developers struggle with understanding at first. Arnd ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build 2021-12-20 20:31 ` Pavel Machek 2021-12-20 20:49 ` Arnd Bergmann @ 2021-12-22 7:54 ` Greg Kroah-Hartman 1 sibling, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2021-12-22 7:54 UTC (permalink / raw) To: Pavel Machek Cc: linux-kernel, stable, Randy Dunlap, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Sasha Levin On Mon, Dec 20, 2021 at 09:31:36PM +0100, Pavel Machek wrote: > Hi! > > > From: Randy Dunlap <rdunlap@infradead.org> > > > > [ Upstream commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 ] > > > > The hyperv utilities use PTP clock interfaces and should depend a > > a kconfig symbol such that they will be built as a loadable module or > > builtin so that linker errors do not happen. > > > > Prevents these build errors: > > > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > This is bad idea for 4.19: > > > +++ b/drivers/hv/Kconfig > > @@ -16,6 +16,7 @@ config HYPERV_TSCPAGE > > config HYPERV_UTILS > > tristate "Microsoft Hyper-V Utilities driver" > > depends on HYPERV && CONNECTOR && NLS > > + depends on PTP_1588_CLOCK_OPTIONAL > > help > > Select this option to enable the Hyper-V Utilities. > > grep -ri PTP_1588_CLOCK_OPTIONAL . > > Results in no result in 4.19. So this will break hyperv. No results in > 5.10, either, so it is bad idea there, too. Thanks, I will go delete it from all queues. greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-22 7:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211220143023.451982183@linuxfoundation.org>
2021-12-20 14:34 ` [PATCH 4.19 18/56] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Greg Kroah-Hartman
2021-12-20 20:31 ` Pavel Machek
2021-12-20 20:49 ` Arnd Bergmann
2021-12-22 7:54 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).