From: Wei Liu <wei.liu@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
netdev@vger.kernel.org, shayagr@amazon.com, akiyano@amazon.com,
darinzon@amazon.com, ndagan@amazon.com, saeedb@amazon.com,
sgoutham@marvell.com, kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
grygorii.strashko@ti.com, sameehj@amazon.com,
chenhao288@hisilicon.com, moyufeng@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] net: add includes masked by netdevice.h including uapi/bpf.h
Date: Thu, 6 Jan 2022 13:03:37 +0000 [thread overview]
Message-ID: <20220106130337.qtvjgffwlyzy7j2y@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20211230012742.770642-2-kuba@kernel.org>
On Wed, Dec 29, 2021 at 05:27:41PM -0800, Jakub Kicinski wrote:
> Add missing includes unmasked by the subsequent change.
>
> Mostly network drivers missing an include for XDP_PACKET_HEADROOM.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[...]
> drivers/net/ethernet/microsoft/mana/mana_en.c | 2 ++
This seems trivially correct, so in case an ack is needed:
Acked-by: Wei Liu <wei.liu@kernel.org>
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index c1d5a374b967..2ece9e90dc50 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -1,6 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> /* Copyright (c) 2021, Microsoft Corporation. */
>
> +#include <uapi/linux/bpf.h>
> +
> #include <linux/inetdevice.h>
> #include <linux/etherdevice.h>
> #include <linux/ethtool.h>
prev parent reply other threads:[~2022-01-06 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211230012742.770642-1-kuba@kernel.org>
2021-12-30 1:27 ` [PATCH bpf-next v2 1/2] net: add includes masked by netdevice.h including uapi/bpf.h Jakub Kicinski
2022-01-06 13:03 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106130337.qtvjgffwlyzy7j2y@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=akiyano@amazon.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenhao288@hisilicon.com \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=decui@microsoft.com \
--cc=grygorii.strashko@ti.com \
--cc=haiyangz@microsoft.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=moyufeng@huawei.com \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=sgoutham@marvell.com \
--cc=shayagr@amazon.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox