From: Wei Liu <wei.liu@kernel.org>
To: Juan Vazquez <juvazq@linux.microsoft.com>
Cc: Miaoqian Lin <linmq006@gmail.com>,
decui@microsoft.com, gregkh@linuxfoundation.org,
haiyangz@microsoft.com, kys@microsoft.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
sthemmin@microsoft.com, wei.liu@kernel.org
Subject: Re: [PATCH v2] Drivers: hv: vmbus: Fix memory leak in vmbus_add_channel_kobj
Date: Mon, 7 Feb 2022 17:54:55 +0000 [thread overview]
Message-ID: <20220207175455.ftlpbzzuq5wqducc@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20220206145556.72obb2qxbsktw3sc@surface>
On Sun, Feb 06, 2022 at 06:55:56AM -0800, Juan Vazquez wrote:
> On Fri, Feb 04, 2022 at 01:30:08AM +0800, Miaoqian Lin wrote:
> > kobject_init_and_add() takes reference even when it fails.
> > According to the doc of kobject_init_and_add()：
> >
> > If this function returns an error, kobject_put() must be called to
> > properly clean up the memory associated with the object.
> >
> > Fix memory leak by calling kobject_put().
> >
> > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > Changes in v2:
> > - Add cleanup when sysfs_create_group() fails
> >
> > kobject_uevent() is used for notifying userspace by sending an uevent,
> > I don't think we need to do error handling for it.
>
> Thanks for the patch. It looks good to me.
>
> Reviewed-by: Juan Vazquez <juvazq@linux.microsoft.com>
Applied to hyperv-fixes. Thanks.
prev parent reply other threads:[~2022-02-07 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 5:52 [PATCH] Drivers: hv: vmbus: Fix memory leak in vmbus_add_channel_kobj Miaoqian Lin
2022-01-28 21:56 ` Juan Vazquez
2022-02-03 12:44 ` Wei Liu
2022-02-03 17:30 ` [PATCH v2] " Miaoqian Lin
2022-02-06 14:55 ` Juan Vazquez
2022-02-07 17:54 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207175455.ftlpbzzuq5wqducc@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=juvazq@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linmq006@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox