* [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build [not found] <20220414110855.141582785@linuxfoundation.org> @ 2022-04-14 13:06 ` Greg Kroah-Hartman 2022-04-14 15:32 ` Randy Dunlap 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-04-14 13:06 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, stable, Randy Dunlap, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Petr Štetiar From: Randy Dunlap <rdunlap@infradead.org> commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. The hyperv utilities use PTP clock interfaces and should depend a a kconfig symbol such that they will be built as a loadable module or builtin so that linker errors do not happen. Prevents these build errors: ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' ld: drivers/hv/hv_util.o: in function `hv_timesync_init': hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Cc: Wei Liu <wei.liu@kernel.org> Cc: Dexuan Cui <decui@microsoft.com> Cc: linux-hyperv@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Michael Kelley <mikelley@microsoft.com> Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org Signed-off-by: Wei Liu <wei.liu@kernel.org> Cc: Petr Štetiar <ynezz@true.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/hv/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -17,6 +17,7 @@ config HYPERV_TIMER config HYPERV_UTILS tristate "Microsoft Hyper-V Utilities driver" depends on HYPERV && CONNECTOR && NLS + depends on PTP_1588_CLOCK_OPTIONAL help Select this option to enable the Hyper-V Utilities. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build 2022-04-14 13:06 ` [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Greg Kroah-Hartman @ 2022-04-14 15:32 ` Randy Dunlap 2022-04-14 15:47 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2022-04-14 15:32 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-kernel Cc: stable, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Petr Štetiar On 4/14/22 06:06, Greg Kroah-Hartman wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. > > The hyperv utilities use PTP clock interfaces and should depend a > a kconfig symbol such that they will be built as a loadable module or > builtin so that linker errors do not happen. > > Prevents these build errors: > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: "K. Y. Srinivasan" <kys@microsoft.com> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: Stephen Hemminger <sthemmin@microsoft.com> > Cc: Wei Liu <wei.liu@kernel.org> > Cc: Dexuan Cui <decui@microsoft.com> > Cc: linux-hyperv@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org > Signed-off-by: Wei Liu <wei.liu@kernel.org> > Cc: Petr Štetiar <ynezz@true.cz> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/hv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -17,6 +17,7 @@ config HYPERV_TIMER > config HYPERV_UTILS > tristate "Microsoft Hyper-V Utilities driver" > depends on HYPERV && CONNECTOR && NLS > + depends on PTP_1588_CLOCK_OPTIONAL AFAICT PTP_1588_CLOCK_OPTIONAL does not exist in 5.4 kernels, so this should not be used there. > help > Select this option to enable the Hyper-V Utilities. > > > -- ~Randy ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build 2022-04-14 15:32 ` Randy Dunlap @ 2022-04-14 15:47 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-04-14 15:47 UTC (permalink / raw) To: Randy Dunlap Cc: linux-kernel, stable, kernel test robot, Arnd Bergmann, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger, Wei Liu, Dexuan Cui, linux-hyperv, Michael Kelley, Petr Štetiar On Thu, Apr 14, 2022 at 08:32:26AM -0700, Randy Dunlap wrote: > > > On 4/14/22 06:06, Greg Kroah-Hartman wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > commit 1dc2f2b81a6a9895da59f3915760f6c0c3074492 upstream. > > > > The hyperv utilities use PTP clock interfaces and should depend a > > a kconfig symbol such that they will be built as a loadable module or > > builtin so that linker errors do not happen. > > > > Prevents these build errors: > > > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit': > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister' > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init': > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register' > > > > Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Reported-by: kernel test robot <lkp@intel.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: "K. Y. Srinivasan" <kys@microsoft.com> > > Cc: Haiyang Zhang <haiyangz@microsoft.com> > > Cc: Stephen Hemminger <sthemmin@microsoft.com> > > Cc: Wei Liu <wei.liu@kernel.org> > > Cc: Dexuan Cui <decui@microsoft.com> > > Cc: linux-hyperv@vger.kernel.org > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > Link: https://lore.kernel.org/r/20211126023316.25184-1-rdunlap@infradead.org > > Signed-off-by: Wei Liu <wei.liu@kernel.org> > > Cc: Petr Štetiar <ynezz@true.cz> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/hv/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > --- a/drivers/hv/Kconfig > > +++ b/drivers/hv/Kconfig > > @@ -17,6 +17,7 @@ config HYPERV_TIMER > > config HYPERV_UTILS > > tristate "Microsoft Hyper-V Utilities driver" > > depends on HYPERV && CONNECTOR && NLS > > + depends on PTP_1588_CLOCK_OPTIONAL > > AFAICT PTP_1588_CLOCK_OPTIONAL does not exist in 5.4 kernels, > so this should not be used there. Gotta love it when people lie in Fixes: tags :( I'll go drop this, thanks! greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-14 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220414110855.141582785@linuxfoundation.org>
2022-04-14 13:06 ` [PATCH 5.4 004/475] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build Greg Kroah-Hartman
2022-04-14 15:32 ` Randy Dunlap
2022-04-14 15:47 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).