From: Wei Liu <wei.liu@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>,
quic_jhugo@quicinc.com, wei.liu@kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
lpieralisi@kernel.org, bhelgaas@google.com,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, mikelley@microsoft.com,
robh@kernel.org, kw@linux.com, alex.williamson@redhat.com,
boqun.feng@gmail.com, Boqun.Feng@microsoft.com,
Carl Vanderlip <quic_carlv@quicinc.com>
Subject: Re: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi_msg()
Date: Fri, 19 Aug 2022 15:52:42 +0000 [thread overview]
Message-ID: <20220819155242.w32vcwobt4ucvpyv@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20220815203545.GA1971949@bhelgaas>
On Mon, Aug 15, 2022 at 03:35:45PM -0500, Bjorn Helgaas wrote:
> s/definiton/definition/ in subject
> (only if you have other occasion to repost this)
>
> On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > The local variable 'vector' must be u32 rather than u8: see the
> > struct hv_msi_desc3.
> >
> > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > hv_msi_desc2 and hv_msi_desc3.
> >
> > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> > Cc: Carl Vanderlip <quic_carlv@quicinc.com>
>
> Looks like Wei has been applying most changes to pci-hyperv.c, so I
> assume the same will happen here.
I can take care of this one via hyperv-fixes, but ...
>
> > ---
> >
> > The patch should be appplied after the earlier patch:
> > [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
> > https://lwn.net/ml/linux-kernel/20220804025104.15673-1-decui%40microsoft.com/
> >
... this patch looks to be rejected.
Thanks,
Wei.
next prev parent reply other threads:[~2022-08-19 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 18:55 [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi_msg() Dexuan Cui
2022-08-15 20:35 ` Bjorn Helgaas
2022-08-15 21:10 ` Dexuan Cui
2022-08-19 15:52 ` Wei Liu [this message]
2022-08-19 15:57 ` Dexuan Cui
2022-08-16 16:01 ` Jeffrey Hugo
2022-08-16 21:14 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819155242.w32vcwobt4ucvpyv@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=Boqun.Feng@microsoft.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=boqun.feng@gmail.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mikelley@microsoft.com \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox