From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C903CC54EBE for ; Sat, 14 Jan 2023 01:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230492AbjANB5h (ORCPT ); Fri, 13 Jan 2023 20:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbjANB5g (ORCPT ); Fri, 13 Jan 2023 20:57:36 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75DBC89BEE for ; Fri, 13 Jan 2023 17:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673661408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hwyNBnBNcOY5o3TI1UxsJTjGkKbM0dQkaLFkc1W7j5I=; b=ffASZqYDMSBL7KOvTO5bxdjaht0RjJlqcPePn2bm3/LijpO7QgyIw4eK5rcCy4bXovTdhn PBMTHCpSiRU83brBcp59pQk2yl9eVFAcbXnOH7091a6sA+X77BNzsSiyHL4QEB44txnDfy Vc1pOzYJ8RkB3Ytfgx/LdP3AECltNBQ= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-670-_S26wQmqNsKrjGJY2N1R_Q-1; Fri, 13 Jan 2023 20:56:47 -0500 X-MC-Unique: _S26wQmqNsKrjGJY2N1R_Q-1 Received: by mail-qk1-f198.google.com with SMTP id bp6-20020a05620a458600b006ffd3762e78so16368409qkb.13 for ; Fri, 13 Jan 2023 17:56:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hwyNBnBNcOY5o3TI1UxsJTjGkKbM0dQkaLFkc1W7j5I=; b=TJuNJUNQk7kI7KM7PrKKeE/luXxZCxzkFd6cj0UThpzu11YKGz+S+0w3yE/Ah39DWF 1twTqSa6eI3SnBcWfT6YiWJDityohABK0fo54iS4d4Z9yYmev8sl6lZDMDKz7NZ+TD3w 6NLwa9VqlKTRhux80F9RwRH/fTQB+RY7NPOexmJ0r0fdV6AGjtQS+A4cyqkkI4gMP/mj 52eB/37f4BISp2wEItMOShf6ahWs5+7bE48WC2wHRk9gPuQ20mdMryInGwLN8GcWqsWR Sf1WFPBslA7ylc2ZRLPJjaLOwj/mJFc4jMqwG9kc/hSvfrw6sK2OZX6ajlAR4voxOnX/ 9fKA== X-Gm-Message-State: AFqh2krREgy86tBQye+uh7FcdO59Cd8dV1DpnGaYA+8fTHLrBzkOGdmj KHTi/FD82P9UCVV1wWR/hZkUiCroy06bzHfye5blpg+Spa+PoJZ5Vi5z1KFZWJITpJNjlnmLrFc ip0Ykin1YfN3fl9ecWXY6Yqay X-Received: by 2002:a0c:8067:0:b0:4c6:f5e2:f13a with SMTP id 94-20020a0c8067000000b004c6f5e2f13amr115831009qva.37.1673661407150; Fri, 13 Jan 2023 17:56:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXuZl/PpthyxDzFL+KrWDgOWGYjIZfEmrSWqy8vxMd9Aa5yd8txUc+zlb9SV3mWCyRBu7AkMNA== X-Received: by 2002:a0c:8067:0:b0:4c6:f5e2:f13a with SMTP id 94-20020a0c8067000000b004c6f5e2f13amr115830987qva.37.1673661406887; Fri, 13 Jan 2023 17:56:46 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id w22-20020a05620a425600b006cbc00db595sm13774578qko.23.2023.01.13.17.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 17:56:46 -0800 (PST) From: Tom Rix To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mikelley@microsoft.com, jinankjain@linux.microsoft.com, nunodasneves@linux.microsoft.com Cc: x86@kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] x86/hyperv: conditionally build hv_get_nested_reg() Date: Fri, 13 Jan 2023 20:56:43 -0500 Message-Id: <20230114015643.3950640-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org cppcheck reports [arch/x86/kernel/cpu/mshyperv.c:44]: (style) The function 'hv_get_nested_reg' is never used. hv_get_nested_reg() is built unconditially but is only used conditionally in hv_get_register() and hv_set_register() by CONFIG_HYPERV. Move the conditional #if to also include hv_get_nested_reg() Fixes: 89acd9b2ff8e ("Drivers: hv: Setup synic registers in case of nested root partition") Signed-off-by: Tom Rix --- arch/x86/kernel/cpu/mshyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index b8bb13daacf7..9ca202970569 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -41,6 +41,7 @@ bool hv_root_partition; bool hv_nested; struct ms_hyperv_info ms_hyperv; +#if IS_ENABLED(CONFIG_HYPERV) static inline unsigned int hv_get_nested_reg(unsigned int reg) { switch (reg) { @@ -61,7 +62,6 @@ static inline unsigned int hv_get_nested_reg(unsigned int reg) } } -#if IS_ENABLED(CONFIG_HYPERV) u64 hv_get_non_nested_register(unsigned int reg) { u64 value; -- 2.27.0