From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72864C77B6E for ; Thu, 13 Apr 2023 13:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbjDMNEe (ORCPT ); Thu, 13 Apr 2023 09:04:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbjDMNEe (ORCPT ); Thu, 13 Apr 2023 09:04:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7000B6A42; Thu, 13 Apr 2023 06:04:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08E7E61574; Thu, 13 Apr 2023 13:04:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C4B3C433EF; Thu, 13 Apr 2023 13:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681391072; bh=45Dth3u/C8VS64hODTY5Dhhg4w/QuvdiQ3hHX+zxnhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BtGbMQ9T+VLC5Hz2tZj+h9EK2KX7RsXaasedk2hn9l8ca7NBMa6tjnyD9JdYaZnxH GmpzQjuFwlvR74fZELsiqYV4MhOTOhlRmswSZR5o9CXgNDzdCJO0A0sbUp/LuJ5c5L 8UrVkagVapbfczpRG/ddGQZAp1tyIdjKleF8FFYxqDFKlw7nGlgYPhO9ENVY1xiEPz WuL/JuIEmMfd0Co+O8/srSEv/G3hPPc+BZv4XnE5MqdtTasSeiz5vSupn4PEqHnvGX qKfG5BCJn/c03b0ocvumaRKaR9ILH6ai9ryJtW0WM7d1QjUBLPcS1QYNyunZopT9Wj sDvfs0hDHZgwg== Date: Thu, 13 Apr 2023 16:04:28 +0300 From: Leon Romanovsky To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, decui@microsoft.com, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com, hawk@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3,net-next, 2/4] net: mana: Refactor RX buffer allocation code to prepare for various MTU Message-ID: <20230413130428.GO17993@unreal> References: <1681334163-31084-1-git-send-email-haiyangz@microsoft.com> <1681334163-31084-3-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1681334163-31084-3-git-send-email-haiyangz@microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, Apr 12, 2023 at 02:16:01PM -0700, Haiyang Zhang wrote: > Move out common buffer allocation code from mana_process_rx_cqe() and > mana_alloc_rx_wqe() to helper functions. > Refactor related variables so they can be changed in one place, and buffer > sizes are in sync. > > Signed-off-by: Haiyang Zhang > Reviewed-by: Jesse Brandeburg > --- > V3: > Refectored to multiple patches for readability. Suggested by Jacob Keller. > > V2: > Refectored to multiple patches for readability. Suggested by Yunsheng Lin. > > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 154 ++++++++++-------- > include/net/mana/mana.h | 6 +- > 2 files changed, 91 insertions(+), 69 deletions(-) <...> > +static void *mana_get_rxfrag(struct mana_rxq *rxq, struct device *dev, > + dma_addr_t *da, bool is_napi) > +{ > + struct page *page; > + void *va; > + > + /* Reuse XDP dropped page if available */ > + if (rxq->xdp_save_va) { > + va = rxq->xdp_save_va; > + rxq->xdp_save_va = NULL; > + } else { > + page = dev_alloc_page(); Documentation/networking/page_pool.rst 10 Basic use involves replacing alloc_pages() calls with the 11 page_pool_alloc_pages() call. Drivers should use page_pool_dev_alloc_pages() 12 replacing dev_alloc_pages(). General question, is this sentence applicable to all new code or only for XDP related paths? Thanks