From: Olaf Hering <olaf@aepfle.de>
To: Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Long Li <longli@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM
Date: Sat, 22 Apr 2023 13:55:16 +0200 [thread overview]
Message-ID: <20230422135516.70a63d96.olaf@aepfle.de> (raw)
In-Reply-To: <1682152783-21787-1-git-send-email-shradhagupta@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Sat, 22 Apr 2023 01:39:43 -0700 Shradha Gupta <shradhagupta@linux.microsoft.com>:
> The next part of this support is to let the Distro vendors consume
> these modified implementations to the new configuration format.
The approach taken here makes it difficult to consume the changes.
The way it is implemented means a given variant of the daemon produces
either ifcfg or .nmconnection files. In practice there is a single
source of hv_kvp_daemon.c which is compatible with all versions of a distro.
IMO the new feature should be implemented such that hv_kvp_daemon
writes both files. Then the tooling can decide which of the files will
actually be used.
I think the configuration file for NetworkManager should have the
suffix .nmconnection, even if it may not be mandatory.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-22 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <=1B[200~<ZDdbfiMD?= =?ISO-8859-1?Q?8iq2OH9s@liuwe-d?= =?ISO-8859-1?Q?evbox-debian-v2>
2023-04-22 8:39 ` [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM Shradha Gupta
2023-04-22 11:55 ` Olaf Hering [this message]
2023-05-05 5:48 ` [PATCH v3] " Shradha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230422135516.70a63d96.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).