From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30DAC77B7F for ; Mon, 8 May 2023 06:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232657AbjEHGJo (ORCPT ); Mon, 8 May 2023 02:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbjEHGJn (ORCPT ); Mon, 8 May 2023 02:09:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF28413875; Sun, 7 May 2023 23:09:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C07761ECE; Mon, 8 May 2023 06:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EE66C433EF; Mon, 8 May 2023 06:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683526181; bh=DR9ESMaKwm8NsHUBK4z/TFCX3IDQUJxokLl7RszMNZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=clpL97EK1OY4BMwKvAvSWx4MZl136IHuQy/dFELAzOAo1G4EjBD6LZkugfuNKw6Ld IYQheXg0amnlyfWvRZaITSBTUGzWcWIOzEJf8pK9jGdwncgLIOFiPIfeVdlhsXgK4k 0aPV/sRclXYRdqrJUxe84i4Vdy2ERRru8Gd07uQz7MKv5T0sId42mVzu6VeOV/aY7I SScnoxYjSRuKWjXqaRkoTU7lp9iifllM4h6U0G3vwP7r/IiJ+AQS7by6X16iZZ9kgv xex9BGquDw5kFSog46z/srIce7pSx4585PC0lSi7C61/nNX69xka6ekqzwdBPX0x6R W/LSfWBh9i8kw== Date: Mon, 8 May 2023 09:09:38 +0300 From: Leon Romanovsky To: Haiyang Zhang Cc: Long Li , Jason Gunthorpe , Ajay Sharma , Dexuan Cui , KY Srinivasan , Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "linux-rdma@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to enable RX coalescing Message-ID: <20230508060938.GA6195@unreal> References: <1683312708-24872-1-git-send-email-longli@linuxonhyperv.com> <20230507081053.GD525452@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Sun, May 07, 2023 at 09:39:27PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Leon Romanovsky > > Sent: Sunday, May 7, 2023 4:11 AM > > To: Long Li > > Cc: Jason Gunthorpe ; Ajay Sharma > > ; Dexuan Cui ; KY > > Srinivasan ; Haiyang Zhang ; > > Wei Liu ; David S. Miller ; Eric > > Dumazet ; Jakub Kicinski ; Paolo > > Abeni ; linux-rdma@vger.kernel.org; linux- > > hyperv@vger.kernel.org; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to > > enable RX coalescing > > > > On Fri, May 05, 2023 at 11:51:48AM -0700, longli@linuxonhyperv.com > > wrote: > > > From: Long Li > > > > > > With RX coalescing, one CQE entry can be used to indicate multiple packets > > > on the receive queue. This saves processing time and PCI bandwidth over > > > the CQ. > > > > > > Signed-off-by: Long Li > > > --- > > > drivers/infiniband/hw/mana/qp.c | 5 ++++- > > > include/net/mana/mana.h | 17 +++++++++++++++++ > > > 2 files changed, 21 insertions(+), 1 deletion(-) > > > > Why didn't you change mana_cfg_vport_steering() too? > > The mana_cfg_vport_steering() is for mana_en (Enthernet) driver, not the > mana_ib driver. > > The changes for mana_en will be done in a separate patch together with > changes for mana_en RX code patch to support multiple packets / CQE. I'm aware of the difference between mana_en and mana_ib. The change you proposed doesn't depend on "support multiple packets / CQE." and works perfectly with one packet/CQE also, does it? Thanks > > Thanks, > - Haiyang >