From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3248C77B75 for ; Tue, 9 May 2023 07:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233731AbjEIHam (ORCPT ); Tue, 9 May 2023 03:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbjEIHal (ORCPT ); Tue, 9 May 2023 03:30:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A339A7A9D; Tue, 9 May 2023 00:30:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39DE2643AB; Tue, 9 May 2023 07:30:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB0DDC433D2; Tue, 9 May 2023 07:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683617438; bh=8muEFwwV/fMT6/BkEavYZNU3BkDJkYBlCsjz3eXYwpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O0jAFc4AjkqBgTofQ2McerbR+WAzpALl8ybRyuubnlmPPpxizbGh1MIKqRmtNRqq7 9ceWpHWPT+BGtOfeP0uCDs/bJUzeLwoGZEC/rtta1Q/lRecyT9hyxOJOkVdd7vSKV/ qL7w/sZSD1pO2q951gMCjSfSK/mgNGW0t0CwgfU3ytKMJHdTDqGA2Tfav44OIzhI22 Nch1sC3hWOP7wnnmYcPo28MrMjgipYq5nyXocaHnzTWrHyuh5DmV9apWnPLxG2s38n G/jftRhXkzunLll2ZowAs21Zd7ybw17SKst/TarQfbMnvBd3S0d+4GgiVo/6UbHl3d EgfzlGd8XlbLA== Date: Tue, 9 May 2023 10:30:34 +0300 From: Leon Romanovsky To: Haiyang Zhang Cc: Long Li , Jason Gunthorpe , Ajay Sharma , Dexuan Cui , KY Srinivasan , Wei Liu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "linux-rdma@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to enable RX coalescing Message-ID: <20230509073034.GA38143@unreal> References: <1683312708-24872-1-git-send-email-longli@linuxonhyperv.com> <20230507081053.GD525452@unreal> <20230508060938.GA6195@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Mon, May 08, 2023 at 02:45:44PM +0000, Haiyang Zhang wrote: > > > > -----Original Message----- > > From: Leon Romanovsky > > Sent: Monday, May 8, 2023 2:10 AM > > To: Haiyang Zhang > > Cc: Long Li ; Jason Gunthorpe ; Ajay > > Sharma ; Dexuan Cui ; > > KY Srinivasan ; Wei Liu ; David S. > > Miller ; Eric Dumazet ; > > Jakub Kicinski ; Paolo Abeni ; linux- > > rdma@vger.kernel.org; linux-hyperv@vger.kernel.org; > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req to > > enable RX coalescing > > > > On Sun, May 07, 2023 at 09:39:27PM +0000, Haiyang Zhang wrote: > > > > > > > > > > -----Original Message----- > > > > From: Leon Romanovsky > > > > Sent: Sunday, May 7, 2023 4:11 AM > > > > To: Long Li > > > > Cc: Jason Gunthorpe ; Ajay Sharma > > > > ; Dexuan Cui ; KY > > > > Srinivasan ; Haiyang Zhang > > ; > > > > Wei Liu ; David S. Miller ; Eric > > > > Dumazet ; Jakub Kicinski ; > > Paolo > > > > Abeni ; linux-rdma@vger.kernel.org; linux- > > > > hyperv@vger.kernel.org; netdev@vger.kernel.org; linux- > > > > kernel@vger.kernel.org > > > > Subject: Re: [PATCH] RDMA/mana_ib: Use v2 version of cfg_rx_steer_req > > to > > > > enable RX coalescing > > > > > > > > On Fri, May 05, 2023 at 11:51:48AM -0700, longli@linuxonhyperv.com > > > > wrote: > > > > > From: Long Li > > > > > > > > > > With RX coalescing, one CQE entry can be used to indicate multiple > > packets > > > > > on the receive queue. This saves processing time and PCI bandwidth over > > > > > the CQ. > > > > > > > > > > Signed-off-by: Long Li > > > > > --- > > > > > drivers/infiniband/hw/mana/qp.c | 5 ++++- > > > > > include/net/mana/mana.h | 17 +++++++++++++++++ > > > > > 2 files changed, 21 insertions(+), 1 deletion(-) > > > > > > > > Why didn't you change mana_cfg_vport_steering() too? > > > > > > The mana_cfg_vport_steering() is for mana_en (Enthernet) driver, not the > > > mana_ib driver. > > > > > > The changes for mana_en will be done in a separate patch together with > > > changes for mana_en RX code patch to support multiple packets / CQE. > > > > I'm aware of the difference between mana_en and mana_ib. > > > > The change you proposed doesn't depend on "support multiple packets / > > CQE." > > and works perfectly with one packet/CQE also, does it? > > No. > If we add the following setting to the mana_en / mana_cfg_vport_steering(), > the NIC may put multiple packets in one CQE, so we need to have the changes > for mana_en RX code path to support multiple packets / CQE. > + req->cqe_coalescing_enable = true; You can leave "cqe_coalescing_enable = false" for ETH and still reuse your new v2 struct. H> > So we plan to set this cqe_coalescing_enable, and the changes for mana_en > RX code path to support multiple packets / CQE in another patch. And how does it work with IB without changing anything except this proposed patch? Thanks > > Thanks, > - Haiyang >