From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A807C001B0 for ; Mon, 26 Jun 2023 21:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbjFZVxU (ORCPT ); Mon, 26 Jun 2023 17:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231267AbjFZVwn (ORCPT ); Mon, 26 Jun 2023 17:52:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AFC63595; Mon, 26 Jun 2023 14:51:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C50EE60F94; Mon, 26 Jun 2023 21:51:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06F00C43215; Mon, 26 Jun 2023 21:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687816265; bh=eb+yCFxbRozAavwqY04t+fH+VDJLDITKYEtPv+/vAvI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U0GQW/b0DlNRsUpAi93BUtpM3aKIeTtmqW7T3Y/kifa1y9U3DkujvJY1QYOKyIOMZ yoFNiSQFeIQdhhijta7Y49Q3Njdsb7rdDM0YknlW3H6UWOxGTGL8PXEdT+GWutfnGZ r+b8KiRE1M+QVWSmli2p+dWgTIE7REFHqrr0KE1Ni02VlYQ3GXGPBHOkKHCz3HUouE 5BMqBw1NnYNN4SpPO/Antl19r4QM/iaJ/hGe+8XCALsJiXT+jV4se4klBao4HZpa4s Ovbvt+2q1DR6GPkbQc/nnk2Dk05vwugfqov9jOoLnOEB5kJ5ujGA9tdjHotItjrrSu KGahK49DIzf8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Kelley , "Martin K . Petersen" , Sasha Levin , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jejb@linux.ibm.com, linux-hyperv@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 7/9] scsi: storvsc: Always set no_report_opcodes Date: Mon, 26 Jun 2023 17:50:55 -0400 Message-Id: <20230626215057.179363-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626215057.179363-1-sashal@kernel.org> References: <20230626215057.179363-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.118 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org From: Michael Kelley [ Upstream commit 31d16e712bdcaee769de4780f72ff8d6cd3f0589 ] Hyper-V synthetic SCSI devices do not support the MAINTENANCE_IN SCSI command, so scsi_report_opcode() always fails, resulting in messages like this: hv_storvsc : tag#205 cmd 0xa3 status: scsi 0x2 srb 0x86 hv 0xc0000001 The recently added support for command duration limits calls scsi_report_opcode() four times as each device comes online, which significantly increases the number of messages logged in a system with many disks. Fix the problem by always marking Hyper-V synthetic SCSI devices as not supporting scsi_report_opcode(). With this setting, the MAINTENANCE_IN SCSI command is not issued and no messages are logged. Signed-off-by: Michael Kelley Link: https://lore.kernel.org/r/1686343101-18930-1-git-send-email-mikelley@microsoft.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/storvsc_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index c9b1500c2ab87..98db7bcbe2af1 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1626,6 +1626,8 @@ static int storvsc_device_configure(struct scsi_device *sdevice) { blk_queue_rq_timeout(sdevice->request_queue, (storvsc_timeout * HZ)); + /* storvsc devices don't support MAINTENANCE_IN SCSI cmd */ + sdevice->no_report_opcodes = 1; sdevice->no_write_same = 1; /* -- 2.39.2