From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098CEEB64DA for ; Wed, 5 Jul 2023 13:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231213AbjGENpY (ORCPT ); Wed, 5 Jul 2023 09:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbjGENpW (ORCPT ); Wed, 5 Jul 2023 09:45:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D667319AF for ; Wed, 5 Jul 2023 06:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688564659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T+o2RTG0Hb65gnco//4sOAJzUPOXWOr/LTu5B+NLPrw=; b=d5J+DoqWckaRpbZQsVgF6QpfsM9si5lYjHctRoNLFT5xwvo4NVepIwnPGi/0kZZBorMAM9 JaOW1fRkdgUd04r0ZLm0lADPvaciEPYSG7wM60xt6h2tEGZJWXHbIPpd8onDsUX3JfvWT3 vIm3qyAO3WdStLhiYsSlAvYGDnA5Gj0= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-kQBTNDd4MzS0QHoQv4QKAg-1; Wed, 05 Jul 2023 09:44:17 -0400 X-MC-Unique: kQBTNDd4MzS0QHoQv4QKAg-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-560c7abdbdcso5173450eaf.0 for ; Wed, 05 Jul 2023 06:44:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688564657; x=1691156657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T+o2RTG0Hb65gnco//4sOAJzUPOXWOr/LTu5B+NLPrw=; b=CM4LOi1HGJO0b59+MdjZhlwUr1J8RxIW5DcUYkpWhbmOqehEOzueHVHVbFyJj16+bY FS5lugAoGI3joPDZ7GtB5ahe6I+XQGv3VMSuYszpEHTmMIzlvJcOd1+OTVWEGAt75DB8 bU/8oRkEZWD2wXOLZPAykkWhmh/1BQ4p+y4EOGbmdvwoT7N70XOVX00hC2zwVQS9addU hIkmwtRNQyNFPgrcXNvi/7XVWmivLZSYzM6PwKqMuhdbjZ3h/fJ6V7bBE38UUV5M7O9a tCeYWMrX8xo6plofVc6LMImz6ifg4Rm6l74zRivqnuCqFDOmvqWnrLMVjE0YUENJ73a9 fwtQ== X-Gm-Message-State: ABy/qLYGSYlpB6MK5nZdCmFOMVLWmK6rwZPnPhwexDG45SYY7f9DsYv9 hVHc63Z4hgfNK130IZ1/Ff3IJUuvyyO2CdE+w+BcnpgqcEPHj6aUPPiyUmsI3tRsypKk3m8fiWT Psbfvmrso8WtnZCxnf4+gpCvC X-Received: by 2002:a05:6358:ce2f:b0:135:24ed:5108 with SMTP id gt47-20020a056358ce2f00b0013524ed5108mr3704007rwb.10.1688564656767; Wed, 05 Jul 2023 06:44:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFGE0zZqSbKFgTrY3B/H+Rx4zZXdmwzYAHOS/f6BcW3q/kf/NXLDYjZFmgseUK8rdA7x+IOmA== X-Received: by 2002:a05:6358:ce2f:b0:135:24ed:5108 with SMTP id gt47-20020a056358ce2f00b0013524ed5108mr3703995rwb.10.1688564656468; Wed, 05 Jul 2023 06:44:16 -0700 (PDT) Received: from localhost.localdomain ([115.96.119.220]) by smtp.googlemail.com with ESMTPSA id v29-20020a63481d000000b00553d27ab0e0sm17550034pga.69.2023.07.05.06.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 06:44:15 -0700 (PDT) From: Ani Sinha To: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui Cc: Ani Sinha , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vmbus_testing: fix wrong python syntax for integer value comparison Date: Wed, 5 Jul 2023 19:14:07 +0530 Message-Id: <20230705134408.6302-1-anisinha@redhat.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org It is incorrect in python to compare integer values using the "is" keyword. The "is" keyword in python is used to compare references to two objects, not their values. Newer version of python3 (version 3.8) throws a warning when such incorrect comparison is made. For value comparison, "==" should be used. Fix this in the code and suppress the following warning: /usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="? Signed-off-by: Ani Sinha --- tools/hv/vmbus_testing | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/vmbus_testing b/tools/hv/vmbus_testing index e7212903dd1d..4467979d8f69 100755 --- a/tools/hv/vmbus_testing +++ b/tools/hv/vmbus_testing @@ -164,7 +164,7 @@ def recursive_file_lookup(path, file_map): def get_all_devices_test_status(file_map): for device in file_map: - if (get_test_state(locate_state(device, file_map)) is 1): + if (get_test_state(locate_state(device, file_map)) == 1): print("Testing = ON for: {}" .format(device.split("/")[5])) else: @@ -203,7 +203,7 @@ def write_test_files(path, value): def set_test_state(state_path, state_value, quiet): write_test_files(state_path, state_value) - if (get_test_state(state_path) is 1): + if (get_test_state(state_path) == 1): if (not quiet): print("Testing = ON for device: {}" .format(state_path.split("/")[5])) -- 2.39.1