From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A71B0C00528 for ; Thu, 3 Aug 2023 19:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbjHCTeS (ORCPT ); Thu, 3 Aug 2023 15:34:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjHCTeR (ORCPT ); Thu, 3 Aug 2023 15:34:17 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC043C3B; Thu, 3 Aug 2023 12:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1691091257; x=1722627257; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PAF0RMMEV11NiHv10JtB52cVSZdppNLxEZQTYoTqDAA=; b=HcL+D8bFKNi/uKFb3CjFAFtAUG/O2WG0zGTuwxGN2WjkiuXLI03nChCN t6DZIMsc51rfJGTuWhTSz3XPmiVRjOWFy4PYwR5mN4V0qXLpZJZD96lZS wGH0GKv/WoCHFeSjMZC84I1OlVNTpl2hqQp5IkIetzLLkmxmd+JoFE8tW AcSJ2SxxxMCBf0bbRgrTG8ywfwVjokgGqphAMbMzxNboBHigbjs2if9HB 5oLB2LNoGpmyEG4DMyTm0ZVjN/sc1j1N33aNU6ffExBGs+EgMH4O5GdoC UsUIRg/wokMmtkpXzwnTjy+CedDRuykZBLekCYCT1cXcNQn7+f7U0KgC/ Q==; X-IronPort-AV: E=Sophos;i="6.01,252,1684825200"; d="scan'208";a="227904296" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Aug 2023 12:34:15 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 3 Aug 2023 12:34:08 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 3 Aug 2023 12:34:08 -0700 Date: Thu, 3 Aug 2023 21:34:07 +0200 From: Horatiu Vultur To: Jakub Kicinski CC: , , , , , , Wei Fang , Gerhard Engleder , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH bpf-next v2 1/3] eth: add missing xdp.h includes in drivers Message-ID: <20230803193407.ehslw4aar6gknttf@soft-dev3-1> References: <20230803010230.1755386-1-kuba@kernel.org> <20230803010230.1755386-2-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20230803010230.1755386-2-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org The 08/02/2023 18:02, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Handful of drivers currently expect to get xdp.h by virtue > of including netdevice.h. This will soon no longer be the case > so add explicit includes. > > Reviewed-by: Wei Fang > Reviewed-by: Gerhard Engleder > Signed-off-by: Jakub Kicinski Reviewed-by: Horatiu Vultur > --- > v2: try a little harder with the alphabetic order of includes > > CC: j.vosburgh@gmail.com > CC: andy@greyhouse.net > CC: shayagr@amazon.com > CC: akiyano@amazon.com > CC: ioana.ciornei@nxp.com > CC: claudiu.manoil@nxp.com > CC: vladimir.oltean@nxp.com > CC: shenwei.wang@nxp.com > CC: xiaoning.wang@nxp.com > CC: linux-imx@nxp.com > CC: dmichail@fungible.com > CC: jeroendb@google.com > CC: pkaligineedi@google.com > CC: shailend@google.com > CC: jesse.brandeburg@intel.com > CC: anthony.l.nguyen@intel.com > CC: horatiu.vultur@microchip.com > CC: UNGLinuxDriver@microchip.com > CC: kys@microsoft.com > CC: haiyangz@microsoft.com > CC: wei.liu@kernel.org > CC: decui@microsoft.com > CC: peppe.cavallaro@st.com > CC: alexandre.torgue@foss.st.com > CC: joabreu@synopsys.com > CC: mcoquelin.stm32@gmail.com > CC: grygorii.strashko@ti.com > CC: longli@microsoft.com > CC: sharmaajay@microsoft.com > CC: daniel@iogearbox.net > CC: hawk@kernel.org > CC: john.fastabend@gmail.com > CC: simon.horman@corigine.com > CC: leon@kernel.org > CC: linux-hyperv@vger.kernel.org > CC: bpf@vger.kernel.org > --- > drivers/net/bonding/bond_main.c | 1 + > drivers/net/ethernet/amazon/ena/ena_netdev.h | 1 + > drivers/net/ethernet/engleder/tsnep.h | 1 + > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 + > drivers/net/ethernet/freescale/enetc/enetc.h | 1 + > drivers/net/ethernet/freescale/fec.h | 1 + > drivers/net/ethernet/fungible/funeth/funeth_txrx.h | 1 + > drivers/net/ethernet/google/gve/gve.h | 1 + > drivers/net/ethernet/intel/igc/igc.h | 1 + > drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 1 + > drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + > drivers/net/ethernet/ti/cpsw_priv.h | 1 + > drivers/net/hyperv/hyperv_net.h | 1 + > drivers/net/tap.c | 1 + > include/net/mana/mana.h | 2 ++ > 16 files changed, 17 insertions(+) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 7a0f25301f7e..2f21cca4fdaf 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -90,6 +90,7 @@ > #include > #endif > #include > +#include > > #include "bonding_priv.h" > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h > index 248b715b4d68..33c923e1261a 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.h > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > > #include "ena_com.h" > diff --git a/drivers/net/ethernet/engleder/tsnep.h b/drivers/net/ethernet/engleder/tsnep.h > index 11b29f56aaf9..6e14c918e3fb 100644 > --- a/drivers/net/ethernet/engleder/tsnep.h > +++ b/drivers/net/ethernet/engleder/tsnep.h > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define TSNEP "tsnep" > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > index d56d7a13262e..bfb6c96c3b2f 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > #include > #include > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/ethernet/freescale/enetc/enetc.h > index 8577cf7699a0..7439739cd81a 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc.h > +++ b/drivers/net/ethernet/freescale/enetc/enetc.h > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > #include "enetc_hw.h" > > diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h > index 8f1edcca96c4..5a0974e62f99 100644 > --- a/drivers/net/ethernet/freescale/fec.h > +++ b/drivers/net/ethernet/freescale/fec.h > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > #if defined(CONFIG_M523x) || defined(CONFIG_M527x) || defined(CONFIG_M528x) || \ > defined(CONFIG_M520x) || defined(CONFIG_M532x) || defined(CONFIG_ARM) || \ > diff --git a/drivers/net/ethernet/fungible/funeth/funeth_txrx.h b/drivers/net/ethernet/fungible/funeth/funeth_txrx.h > index 53b7e95213a8..5eec552a1f24 100644 > --- a/drivers/net/ethernet/fungible/funeth/funeth_txrx.h > +++ b/drivers/net/ethernet/fungible/funeth/funeth_txrx.h > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > /* Tx descriptor size */ > #define FUNETH_SQE_SIZE 64U > diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h > index 4b425bf71ede..a31256f70348 100644 > --- a/drivers/net/ethernet/google/gve/gve.h > +++ b/drivers/net/ethernet/google/gve/gve.h > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > #include "gve_desc.h" > #include "gve_desc_dqo.h" > diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h > index 9db384f66a8e..4bffc3cb502f 100644 > --- a/drivers/net/ethernet/intel/igc/igc.h > +++ b/drivers/net/ethernet/intel/igc/igc.h > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include "igc_hw.h" > > diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.h b/drivers/net/ethernet/microchip/lan966x/lan966x_main.h > index 27f272831ea5..eb7d81b5e9f8 100644 > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.h > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.h > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #include > #include > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index ac2acc9aca9d..21665f114fe9 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -11,6 +11,7 @@ > > #include > #include > +#include > > #include > #include > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > index 4ce5eaaae513..a6d034968654 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > > struct stmmac_resources { > diff --git a/drivers/net/ethernet/ti/cpsw_priv.h b/drivers/net/ethernet/ti/cpsw_priv.h > index 34230145ca0b..0e27c433098d 100644 > --- a/drivers/net/ethernet/ti/cpsw_priv.h > +++ b/drivers/net/ethernet/ti/cpsw_priv.h > @@ -6,6 +6,7 @@ > #ifndef DRIVERS_NET_ETHERNET_TI_CPSW_PRIV_H_ > #define DRIVERS_NET_ETHERNET_TI_CPSW_PRIV_H_ > > +#include > #include > > #include "davinci_cpdma.h" > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h > index c9dd69dbe1b8..810977952f95 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > /* RSS related */ > #define OID_GEN_RECEIVE_SCALE_CAPABILITIES 0x00010203 /* query only */ > diff --git a/drivers/net/tap.c b/drivers/net/tap.c > index 9137fb8c1c42..b196a2a54355 100644 > --- a/drivers/net/tap.c > +++ b/drivers/net/tap.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > > diff --git a/include/net/mana/mana.h b/include/net/mana/mana.h > index 024ad8ddb27e..1ccdca03e166 100644 > --- a/include/net/mana/mana.h > +++ b/include/net/mana/mana.h > @@ -4,6 +4,8 @@ > #ifndef _MANA_H > #define _MANA_H > > +#include > + > #include "gdma.h" > #include "hw_channel.h" > > -- > 2.41.0 > -- /Horatiu