From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599DCC83F1A for ; Tue, 29 Aug 2023 13:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236271AbjH2Nfy (ORCPT ); Tue, 29 Aug 2023 09:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236374AbjH2NfB (ORCPT ); Tue, 29 Aug 2023 09:35:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECAC0E52; Tue, 29 Aug 2023 06:34:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B8956579C; Tue, 29 Aug 2023 13:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65FC3C433C8; Tue, 29 Aug 2023 13:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693316043; bh=/JQIq8+Xe+tEaNmG1PPau7O5jYGCuR4wfNkPxQoPmyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hsrbu6dd2PuS1mQYblV+OsrRGsXwQr9+6XlVeEAlAfA4LyrPvQgXCUcv4oLlrJXVq 1yNnJGDC4Aa37w0vbLIpxwJGIfj9UbSEi/lSdJqQbMfd+/aeUyigeJK3bJn2lq8F86 5ImQPmf1GICHBho5iQKbqq8qEsy1TaJX8Of45NqvUSSEpAx6bpe4E/F4legbqRNgZy T5XJDD/3bOz/04Z91SsOOAS1Hm6Gb6WrUPEM6Cqn0r2dMyNU6yx5t6ylvitkV3J232 p6QQP+9/jBy8BOFEkHEgiA8OaNfL+DILy0c72Nku0o99ZiOA6r+2+E30+bONVPwgUE bfOt3wgZd39nQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Kelley , "Martin K . Petersen" , Sasha Levin , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jejb@linux.ibm.com, linux-hyperv@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 5/6] scsi: storvsc: Always set no_report_opcodes Date: Tue, 29 Aug 2023 09:33:51 -0400 Message-Id: <20230829133352.520671-5-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230829133352.520671-1-sashal@kernel.org> References: <20230829133352.520671-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.254 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org From: Michael Kelley [ Upstream commit 31d16e712bdcaee769de4780f72ff8d6cd3f0589 ] Hyper-V synthetic SCSI devices do not support the MAINTENANCE_IN SCSI command, so scsi_report_opcode() always fails, resulting in messages like this: hv_storvsc : tag#205 cmd 0xa3 status: scsi 0x2 srb 0x86 hv 0xc0000001 The recently added support for command duration limits calls scsi_report_opcode() four times as each device comes online, which significantly increases the number of messages logged in a system with many disks. Fix the problem by always marking Hyper-V synthetic SCSI devices as not supporting scsi_report_opcode(). With this setting, the MAINTENANCE_IN SCSI command is not issued and no messages are logged. Signed-off-by: Michael Kelley Link: https://lore.kernel.org/r/1686343101-18930-1-git-send-email-mikelley@microsoft.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/storvsc_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 8d1b19b2322f5..a91ee2b03c382 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1423,6 +1423,8 @@ static int storvsc_device_configure(struct scsi_device *sdevice) { blk_queue_rq_timeout(sdevice->request_queue, (storvsc_timeout * HZ)); + /* storvsc devices don't support MAINTENANCE_IN SCSI cmd */ + sdevice->no_report_opcodes = 1; sdevice->no_write_same = 1; /* -- 2.40.1