From: Leon Romanovsky <leon@kernel.org>
To: sharmaajay@linuxonhyperv.com
Cc: Long Li <longli@microsoft.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Dexuan Cui <decui@microsoft.com>, Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ajay Sharma <sharmaajay@microsoft.com>
Subject: Re: [Patch v5 0/5] RDMA/mana_ib
Date: Mon, 11 Sep 2023 15:32:31 +0300 [thread overview]
Message-ID: <20230911123231.GB19469@unreal> (raw)
In-Reply-To: <1694105559-9465-1-git-send-email-sharmaajay@linuxonhyperv.com>
On Thu, Sep 07, 2023 at 09:52:34AM -0700, sharmaajay@linuxonhyperv.com wrote:
> From: Ajay Sharma <sharmaajay@microsoft.com>
>
> Change from v4:
> Send qp fatal error event to the context that
> created the qp. Add lookup table for qp.
>
> Ajay Sharma (5):
> RDMA/mana_ib : Rename all mana_ib_dev type variables to mib_dev
> RDMA/mana_ib : Register Mana IB device with Management SW
> RDMA/mana_ib : Create adapter and Add error eq
> RDMA/mana_ib : Query adapter capabilities
> RDMA/mana_ib : Send event to qp
I didn't look very deep into the series and has three very initial comments.
1. Please do git log drivers/infiniband/hw/mana/ and use same format for
commit messages.
2. Don't invent your own index-to-qp query mechanism in last patch and use xarray.
3. Once you decided to export mana_gd_register_device, it hinted me that
it is time to move to auxbus infrastructure.
Thanks
>
> drivers/infiniband/hw/mana/cq.c | 12 +-
> drivers/infiniband/hw/mana/device.c | 81 +++--
> drivers/infiniband/hw/mana/main.c | 288 +++++++++++++-----
> drivers/infiniband/hw/mana/mana_ib.h | 102 ++++++-
> drivers/infiniband/hw/mana/mr.c | 42 ++-
> drivers/infiniband/hw/mana/qp.c | 86 +++---
> drivers/infiniband/hw/mana/wq.c | 21 +-
> .../net/ethernet/microsoft/mana/gdma_main.c | 152 +++++----
> drivers/net/ethernet/microsoft/mana/mana_en.c | 3 +
> include/net/mana/gdma.h | 16 +-
> 10 files changed, 545 insertions(+), 258 deletions(-)
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-09-11 12:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 16:52 [Patch v5 0/5] RDMA/mana_ib sharmaajay
2023-09-07 16:52 ` [Patch v5 1/5] RDMA/mana_ib : Rename all mana_ib_dev type variables to mib_dev sharmaajay
2023-09-07 16:52 ` [Patch v5 2/5] RDMA/mana_ib : Register Mana IB device with Management SW sharmaajay
2023-09-07 16:52 ` [Patch v5 3/5] RDMA/mana_ib : Create adapter and Add error eq sharmaajay
2023-09-07 16:52 ` [Patch v5 4/5] RDMA/mana_ib : Query adapter capabilities sharmaajay
2023-09-07 16:52 ` [Patch v5 5/5] RDMA/mana_ib : Send event to qp sharmaajay
2023-09-11 12:32 ` Leon Romanovsky [this message]
2023-09-11 18:57 ` [EXTERNAL] Re: [Patch v5 0/5] RDMA/mana_ib Ajay Sharma
2023-09-18 8:29 ` Leon Romanovsky
2023-10-16 22:15 ` Ajay Sharma
2023-10-17 7:48 ` Leon Romanovsky
2023-10-17 18:51 ` Ajay Sharma
2023-10-18 0:51 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911123231.GB19469@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@linuxonhyperv.com \
--cc=sharmaajay@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).