From: Vladimir Oltean <olteanv@gmail.com>
To: Justin Stitt <justinstitt@google.com>
Cc: GR-Linux-NIC-Dev@marvell.com, UNGLinuxDriver@microchip.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com,
linux-hyperv@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [PATCH next v2 2/3] checkpatch: add ethtool_sprintf rules
Date: Fri, 27 Oct 2023 01:33:02 +0300 [thread overview]
Message-ID: <20231026223302.4gjjeh7inn3a3llq@skbuf> (raw)
In-Reply-To: <CAFhGd8r-u193pBk2+WWF+sHWEo5ixxEiT=fcSYiuy5W+aWDsbg@mail.gmail.com>
On Thu, Oct 26, 2023 at 03:24:54PM -0700, Justin Stitt wrote:
> There was some discussion here [1] but AFAICT I need to use EMACS
> or configure my vim in a very particular way to get the same formatting
>
> But yeah, look around line 7000 -- lots of this pattern matching code is
> pretty hard to read. Not sure there's much to be done as far as readability
> is concerned.
>
> [1]: https://lore.kernel.org/all/137a309b313cc8a295f3affc704f0da049f233aa.camel@perches.com/
Hard to read because of pattern matching is one thing, but your
indentation is unlike anything else in this file. There are inner curly
brackets which are less indented than the outer curly brackets. I cannot
read/review this, sorry, I hope somebody else can.
next prev parent reply other threads:[~2023-10-26 22:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 21:56 [PATCH next v2 0/3] ethtool: Add ethtool_puts() Justin Stitt
2023-10-26 21:56 ` [PATCH next v2 1/3] ethtool: Implement ethtool_puts() Justin Stitt
2023-10-26 22:02 ` Vladimir Oltean
2023-10-26 22:09 ` Justin Stitt
2023-10-26 22:11 ` Justin Stitt
2023-10-26 22:21 ` Vladimir Oltean
2023-10-26 22:25 ` Vladimir Oltean
2023-10-27 19:38 ` Justin Stitt
2023-10-26 21:56 ` [PATCH next v2 2/3] checkpatch: add ethtool_sprintf rules Justin Stitt
2023-10-26 22:12 ` Vladimir Oltean
2023-10-26 22:24 ` Justin Stitt
2023-10-26 22:33 ` Vladimir Oltean [this message]
2023-10-26 22:38 ` Joe Perches
2023-10-27 19:40 ` Justin Stitt
2023-10-27 21:57 ` Joe Perches
2023-10-26 21:56 ` [PATCH next v2 3/3] treewide: Convert some ethtool_sprintf() to ethtool_puts() Justin Stitt
2023-10-26 22:17 ` Vladimir Oltean
2023-10-27 0:24 ` [PATCH next v2 0/3] ethtool: Add ethtool_puts() Andrew Lunn
2023-10-27 19:32 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026223302.4gjjeh7inn3a3llq@skbuf \
--to=olteanv@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bpf@vger.kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox