From: Greg KH <gregkh@linuxfoundation.org>
To: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, ssengar@microsoft.com
Subject: Re: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size
Date: Sun, 18 Feb 2024 10:11:28 +0100 [thread overview]
Message-ID: <2024021859-provided-hamburger-8b43@gregkh> (raw)
In-Reply-To: <20240218080306.GA26112@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Sun, Feb 18, 2024 at 12:03:06AM -0800, Saurabh Singh Sengar wrote:
> On Sun, Feb 18, 2024 at 08:11:58AM +0100, Greg KH wrote:
> > On Sat, Feb 17, 2024 at 10:03:35AM -0800, Saurabh Sengar wrote:
> > > Add a function to query for the preferred ring buffer size of VMBus
> > > device.
> >
> > That says what you did, but not why you did it.
>
> I thought subsequent patch will make it clear, but I can add more
> info in cover letter. I will enhance this commit as well.
Each patch should stand on its own, as it will be on its own when
committed, right?
I don't know anything is happening "next", nor what any of this means
here, which is required.
Again, what would _you_ want to see if you had to review this?
Along those lines, why not get some internal review, and signed-off-by
first, before asking us to review this for you? You all know this area
the best, and have lots of experience with reviews, right?
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-18 9:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 18:03 [PATCH 0/6] Low speed Hyper-V devices support Saurabh Sengar
2024-02-17 18:03 ` [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size Saurabh Sengar
2024-02-18 7:11 ` Greg KH
2024-02-18 8:03 ` Saurabh Singh Sengar
2024-02-18 9:11 ` Greg KH [this message]
2024-03-12 20:57 ` Long Li
2024-02-17 18:03 ` [PATCH 2/6] uio_hv_generic: Query the ringbuffer size for device Saurabh Sengar
2024-02-19 8:50 ` Greg KH
2024-02-19 9:40 ` Saurabh Singh Sengar
2024-02-19 10:02 ` Greg KH
2024-02-19 10:21 ` Saurabh Singh Sengar
2024-02-17 18:03 ` [PATCH 3/6] uio_hv_generic: Enable interrupt for low speed VMBus devices Saurabh Sengar
2024-03-12 20:59 ` Long Li
2024-02-17 18:03 ` [PATCH 4/6] tools: hv: Add vmbus_bufring Saurabh Sengar
2024-03-13 19:12 ` Long Li
2024-02-17 18:03 ` [PATCH 5/6] tools: hv: Add new fcopy application based on uio driver Saurabh Sengar
2024-02-19 8:53 ` Greg KH
2024-02-19 9:24 ` Saurabh Singh Sengar
2024-02-19 9:52 ` Greg KH
2024-02-19 10:23 ` Saurabh Singh Sengar
2024-03-13 19:23 ` Long Li
2024-02-17 18:03 ` [PATCH 6/6] Drivers: hv: Remove fcopy driver Saurabh Sengar
2024-03-13 19:25 ` Long Li
2024-02-18 7:10 ` [PATCH 0/6] Low speed Hyper-V devices support Greg KH
2024-02-18 7:51 ` Saurabh Singh Sengar
2024-02-18 9:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024021859-provided-hamburger-8b43@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).