* [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations
@ 2024-06-20 22:50 Rachel Menge
2024-06-20 23:03 ` Dexuan Cui
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rachel Menge @ 2024-06-20 22:50 UTC (permalink / raw)
To: linux-hyperv
Cc: kys, haiyangz, wei.liu, decui, longli, chrco, linux-kernel,
Rachel Menge
There are lingering hv_fcopy declarations which do not have definitions.
The fcopy driver was removed in commit ec314f61e4fc ("Drivers: hv: Remove
fcopy driver").
Therefore, remove the hv_fcopy declarations which are no longer needed
or defined.
Fixes: ec314f61e4fc ("Drivers: hv: Remove fcopy driver")
Signed-off-by: Rachel Menge <rachelmenge@linux.microsoft.com>
---
drivers/hv/hyperv_vmbus.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
index 76ac5185a01a..d2856023d53c 100644
--- a/drivers/hv/hyperv_vmbus.h
+++ b/drivers/hv/hyperv_vmbus.h
@@ -380,12 +380,6 @@ void hv_vss_deinit(void);
int hv_vss_pre_suspend(void);
int hv_vss_pre_resume(void);
void hv_vss_onchannelcallback(void *context);
-
-int hv_fcopy_init(struct hv_util_service *srv);
-void hv_fcopy_deinit(void);
-int hv_fcopy_pre_suspend(void);
-int hv_fcopy_pre_resume(void);
-void hv_fcopy_onchannelcallback(void *context);
void vmbus_initiate_unload(bool crash);
static inline void hv_poll_channel(struct vmbus_channel *channel,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations
2024-06-20 22:50 [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations Rachel Menge
@ 2024-06-20 23:03 ` Dexuan Cui
2024-06-21 9:48 ` Saurabh Singh Sengar
2024-06-24 7:06 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Dexuan Cui @ 2024-06-20 23:03 UTC (permalink / raw)
To: Rachel Menge, linux-hyperv@vger.kernel.org
Cc: KY Srinivasan, Haiyang Zhang, wei.liu@kernel.org, Long Li,
chrco@linux.microsoft.com, linux-kernel@vger.kernel.org
> From: Rachel Menge <rachelmenge@linux.microsoft.com>
> Sent: Thursday, June 20, 2024 3:51 PM
> [...]
LGTM
Reviewed-by: Dexuan Cui <decui@microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations
2024-06-20 22:50 [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations Rachel Menge
2024-06-20 23:03 ` Dexuan Cui
@ 2024-06-21 9:48 ` Saurabh Singh Sengar
2024-06-24 7:06 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Saurabh Singh Sengar @ 2024-06-21 9:48 UTC (permalink / raw)
To: Rachel Menge
Cc: linux-hyperv, kys, haiyangz, wei.liu, decui, longli, chrco,
linux-kernel
On Thu, Jun 20, 2024 at 06:50:40PM -0400, Rachel Menge wrote:
> There are lingering hv_fcopy declarations which do not have definitions.
> The fcopy driver was removed in commit ec314f61e4fc ("Drivers: hv: Remove
> fcopy driver").
>
> Therefore, remove the hv_fcopy declarations which are no longer needed
> or defined.
>
> Fixes: ec314f61e4fc ("Drivers: hv: Remove fcopy driver")
> Signed-off-by: Rachel Menge <rachelmenge@linux.microsoft.com>
> ---
> drivers/hv/hyperv_vmbus.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 76ac5185a01a..d2856023d53c 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -380,12 +380,6 @@ void hv_vss_deinit(void);
> int hv_vss_pre_suspend(void);
> int hv_vss_pre_resume(void);
> void hv_vss_onchannelcallback(void *context);
> -
> -int hv_fcopy_init(struct hv_util_service *srv);
> -void hv_fcopy_deinit(void);
> -int hv_fcopy_pre_suspend(void);
> -int hv_fcopy_pre_resume(void);
> -void hv_fcopy_onchannelcallback(void *context);
> void vmbus_initiate_unload(bool crash);
>
> static inline void hv_poll_channel(struct vmbus_channel *channel,
> --
> 2.34.1
>
Thanks for the patch,
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations
2024-06-20 22:50 [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations Rachel Menge
2024-06-20 23:03 ` Dexuan Cui
2024-06-21 9:48 ` Saurabh Singh Sengar
@ 2024-06-24 7:06 ` Wei Liu
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2024-06-24 7:06 UTC (permalink / raw)
To: Rachel Menge
Cc: linux-hyperv, kys, haiyangz, wei.liu, decui, longli, chrco,
linux-kernel
On Thu, Jun 20, 2024 at 06:50:40PM -0400, Rachel Menge wrote:
> There are lingering hv_fcopy declarations which do not have definitions.
> The fcopy driver was removed in commit ec314f61e4fc ("Drivers: hv: Remove
> fcopy driver").
>
> Therefore, remove the hv_fcopy declarations which are no longer needed
> or defined.
>
> Fixes: ec314f61e4fc ("Drivers: hv: Remove fcopy driver")
> Signed-off-by: Rachel Menge <rachelmenge@linux.microsoft.com>
Applied to hyperv-fixes. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-24 7:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 22:50 [PATCH] Drivers: hv: Remove deprecated hv_fcopy declarations Rachel Menge
2024-06-20 23:03 ` Dexuan Cui
2024-06-21 9:48 ` Saurabh Singh Sengar
2024-06-24 7:06 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).